Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add mount cache for docker building#34876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
lunny wants to merge5 commits intogo-gitea:main
base:main
Choose a base branch
Loading
fromlunny:lunny/docker_build_cache

Conversation

lunny
Copy link
Member

@lunnylunny commentedJun 27, 2025
edited
Loading

This PR use cache mounts feature of docker to accelerate the docker image build process.
ref:https://docs.docker.com/build/cache/optimize/#use-cache-mounts

Run docker build locally it will take about242.8s and now it's16s after cached.

TODO:

  • Add shared cache in CI/CD
    cache-from: type=registry,ref=gitea/gitea:buildcache-v1.24    cache-to: type=registry,ref=gitea/gitea:buildcache-v1.24,mode=max

NorthRealm reacted with thumbs up emojiTheFox0x7 and ankurk91 reacted with heart emoji
@lunnylunny added the topic/buildPR changes how Gitea is built, i.e. regarding Docker or the Makefile labelJun 27, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJun 27, 2025
@wxiaoguang
Copy link
Contributor

-> Reduce incremental Docker build times#27998

@wxiaoguang
Copy link
Contributor

wxiaoguang commentedJun 27, 2025
edited
Loading

One more thing, the rootful and rootless can share the some build and binaries. For example, build rootless first (or a common image first), then copy its binaries (gitea,environment-to-ini) to the rootful image.

(Just a hint, not a must)

@wxiaoguang
Copy link
Contributor

Why duplicate so many commands in the yaml, should the commands be in a script?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2This PR needs two approvals by maintainers to be considered for merging.modifies/internaltopic/buildPR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@lunny@wxiaoguang@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp