Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Adds title on branch commit counts#34869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wxiaoguang merged 7 commits intogo-gitea:mainfromajmeese7:feat/commit-count-title
Jul 1, 2025

Conversation

@ajmeese7
Copy link
Contributor

Adds atitle to the commit counts when comparing branches, making it easier for novice users to understand what the numbers mean.

Fixes#34867.

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJun 26, 2025
@github-actionsgithub-actionsbot added the modifies/templatesThis PR modifies the template files labelJun 26, 2025
@lunny
Copy link
Member

It needs to be translationable.

delvh and ajmeese7 reacted with thumbs up emoji

@silverwind
Copy link
Member

Usedata-tooltip-content instead.

delvh and ajmeese7 reacted with thumbs up emoji

@ajmeese7ajmeese7force-pushed thefeat/commit-count-title branch froma60ece2 to556fcf7CompareJune 29, 2025 22:39
@delvh
Copy link
Member

Also, wouldn't it make sense to unify both titles into a single title on the parent element?
So it would compare both behind and ahead in the same title.

@wxiaoguang
Copy link
Contributor

Also, wouldn't it make sense to unify both titles into a single title on the parent element? So it would compare both behind and ahead in the same title.

My thought is that why duplicate the numbers in the tooltip .... could it simply just show a fixed tool tip like "Commits ahead", and let users read the rendered number on the UI?

@ajmeese7
Copy link
ContributorAuthor

Also, wouldn't it make sense to unify both titles into a single title on the parent element? So it would compare both behind and ahead in the same title.

My thought is that why duplicate the numbers in the tooltip .... could it simply just show a fixed tool tip like "Commits ahead", and let users read the rendered number on the UI?

That is what GitLab does, that is the behavior I am emulating

@ajmeese7
Copy link
ContributorAuthor

Also, wouldn't it make sense to unify both titles into a single title on the parent element? So it would compare both behind and ahead in the same title.

Working on this now.

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 30, 2025
@wxiaoguang
Copy link
Contributor

The current texts are not really translatable.

I'd prefer GitHub's wording, so I think we can make it "Behind count: %d, ahead count: %d", then everything can be simplified. Will make some changes.

@wxiaoguang
Copy link
Contributor

Sometimes it's not easy to fine tune the i18n resources ... I can understand why GitHub drops their i18n support on the web UI.

Does the new tooltip look good to you?

image

@ajmeese7
Copy link
ContributorAuthor

Sometimes it's not easy to fine tune the i18n resources ... I can understand why GitHub drops their i18n support on the web UI.

Does the new tooltip look good to you?

image

I think it needs to say "aheadof main" if you want to take this approach

wxiaoguang reacted with thumbs up emoji

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>
@wxiaoguang
Copy link
Contributor

Anything else to improve?

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJul 1, 2025
@wxiaoguangwxiaoguang added this to the1.25.0 milestoneJul 1, 2025
@wxiaoguangwxiaoguang added the type/enhancementAn improvement of existing functionality labelJul 1, 2025
@wxiaoguangwxiaoguang merged commit35f0b5a intogo-gitea:mainJul 1, 2025
26 checks passed
@ajmeese7ajmeese7 deleted the feat/commit-count-title branchJuly 1, 2025 12:05
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJul 2, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Improve html escape (go-gitea#34911)  Adds tooltip on branch commit counts (go-gitea#34869)  Fix PR toggle WIP (go-gitea#34920)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@delvhdelvhdelvh left review comments

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/templatesThis PR modifies the template filesmodifies/translationtype/enhancementAn improvement of existing functionality

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

Tooltip over commit counts for different branches

6 participants

@ajmeese7@lunny@silverwind@delvh@wxiaoguang@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp