Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.9k
Improve notifications to fix commit notification and support release notification#34803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
| if ctx.IsSigned && !release.IsTag { | ||
| err = activities_model.SetReleaseReadBy(ctx, release.ID, ctx.Doer.ID) | ||
| if err != nil { | ||
| ctx.ServerError("SetReleaseReadBy", err) |
wxiaoguangJul 3, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TBH I really had enough for such copy-pasteif ... err != nil { ctx.ServerError(...) }. It's difficult to read, the message mismatches, and the "return" is easy to forget.
Not really related to this PR, but why not introduce a better approach (I have proposed)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you point me to the link for the proposed approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I just reiterated it again recently:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for pointing out. It's a better method than this one. But maybe it should be another PR.
| updatedByIndex := schemas.NewIndex("idx_notification_updated_by", schemas.IndexType) | ||
| updatedByIndex.AddColumn("updated_by") | ||
| indices = append(indices, updatedByIndex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are these indices well-designed and correct?
You can't just add index to every column and expect that "oh it should work".
Does database work really work that way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This highlights a significant design flaw in the current table structure.
In this PR, we introduced a new column, release_id, to support release-type notifications.
This PR improved notifications.