Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix remaining issues aftergopls modernize formatting#34771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 7 commits intogo-gitea:mainfromsilverwind:modfix
Jun 18, 2025

Conversation

@silverwind
Copy link
Member

@silverwindsilverwind commentedJun 18, 2025•
edited
Loading

Followup#34751, fix all remaining marked issues.

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJun 18, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelJun 18, 2025
@silverwindsilverwind added the type/refactoringExisting code has been cleaned up. There should be no new functionality. labelJun 18, 2025
@silverwindsilverwind changed the titleFix remaining issues after modernize formattingFix remaining issues aftergopls modernize formattingJun 18, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 18, 2025
Copy link
Contributor

@wxiaoguangwxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No idea what// from the fixtures means now ......

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJun 18, 2025
@silverwind
Copy link
MemberAuthor

silverwind commentedJun 18, 2025•
edited
Loading

It refers to the removed variable:

expectedIssueCount := 20 // from the fixtures

I guess we can make it more clear.

@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 18, 2025
@lunnylunny added this to the1.25.0 milestoneJun 18, 2025
@lunnylunny merged commit46a1d52 intogo-gitea:mainJun 18, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 18, 2025
@wxiaoguangwxiaoguang deleted the modfix branchJune 18, 2025 23:31
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJun 19, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Upgrade `gopls` to v0.19.0, add `make fix` (go-gitea#34772)  Refactor packages (func name & UI) (go-gitea#34773)  Fix remaining issues after `gopls modernize` formatting (go-gitea#34771)  Fix some package registry problems (go-gitea#34759)  Fix incorrect cli default values and default command (go-gitea#34765)  Support annotated tags when using create release API (go-gitea#31840)  when using rules to delete packages, remove unclean bugs (go-gitea#34632)  Fix readme path and markdown link paste (go-gitea#34755)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny left review comments

@wxiaoguangwxiaoguangwxiaoguang approved these changes

@delvhdelvhdelvh approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/refactoringExisting code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

5 participants

@silverwind@lunny@wxiaoguang@delvh@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp