Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix footnote jump behavior on the issue page.#34621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 8 commits intogo-gitea:mainfromcharles7668:fix/issue_footnote
Jun 9, 2025

Conversation

@charles7668
Copy link
Contributor

@charles7668charles7668 commentedJun 6, 2025
edited
Loading

Close#34511
Close#34590

Add comment ID to the footnote item's id attribute to ensure uniqueness.

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJun 6, 2025
@charles7668charles7668 marked this pull request as draftJune 6, 2025 15:29
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelJun 6, 2025
@charles7668charles7668 marked this pull request as ready for reviewJune 6, 2025 16:16
@lunny
Copy link
Member

It's better to have a test.

@charles7668charles7668 marked this pull request as draftJune 6, 2025 17:12
@lunny
Copy link
Member

Related to#34590

@charles7668charles7668force-pushed thefix/issue_footnote branch 2 times, most recently from1c232e4 toff9efedCompareJune 7, 2025 02:40
@charles7668charles7668 marked this pull request as ready for reviewJune 7, 2025 03:40
@charles7668charles7668 requested a review fromlunnyJune 7, 2025 03:40
@lunnylunny added type/bug backport/v1.24This PR should be backported to Gitea 1.24 labelsJun 9, 2025
lunny
lunny previously approved these changesJun 9, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 9, 2025
@wxiaoguang
Copy link
Contributor

wxiaoguang commentedJun 9, 2025
edited
Loading

I think we should do it directly here, instead of the extra post-processing, and remove the "fnref:" prefix (just like GitHub):

Details

image

@GiteaBotGiteaBot added lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJun 9, 2025
@wxiaoguang
Copy link
Contributor

I think we should do it directly here, instead of the extra post-processing, and remove the "fnref:" prefix (just like GitHub):

To make backport easier, maybe we can use this approach temporarily, will make some new changes.

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 9, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJun 9, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 9, 2025
@lunnylunnyenabled auto-merge (squash)June 9, 2025 16:52
@lunnylunny merged commitc6b2cbd intogo-gitea:mainJun 9, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJun 9, 2025
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestJun 9, 2025
Closego-gitea#34511Closego-gitea#34590 Add comment ID to the footnote item's id attribute to ensure uniqueness.---------Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBotGiteaBot added the backport/doneAll backports for this PR have been created labelJun 9, 2025
lunny pushed a commit that referenced this pull requestJun 9, 2025
Backport#34621 by@charles7668Close#34511Close#34590 Add comment ID to the footnote item's id attribute to ensure uniqueness.Co-authored-by: charles <30816317+charles7668@users.noreply.github.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJun 10, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Fix last admin check when syncing users (go-gitea#34649)  Update x/crypto package and make builtin SSH use default parameters (go-gitea#34667)  Fix "oras" OCI client compatibility (go-gitea#34666)  Fix: skip paths check on tag push events in workflows (go-gitea#34602)  Fix footnote jump behavior on the issue page. (go-gitea#34621)  Only activity tab needs heatmap data loading (go-gitea#34652)  Ignore "Close" error when uploading container blob (go-gitea#34620)  Keeping consistent between UI and API about combined commit status state and fix some bugs (go-gitea#34562)  Refactor FindOrgOptions to use enum instead of bool, fix membership visibility (go-gitea#34629)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull requestJun 17, 2025
## Checklist- [x] go to the last cherry-pick PR (forgejo/forgejo#8040) to figure out how far it went: [gitea@d5bbaee64e](go-gitea/gitea@d5bbaee)- [x] cherry-pick and open PR (forgejo/forgejo#8198)- [ ] have the PR pass the CI- end-to-end (specially important if there are actions related changes)  - [ ] add `run-end-to-end` label  - [ ] check the result- [ ] write release notes- [ ] assign reviewers- [ ] 48h later, last call- merge 1 hour after the last call## Legend- ❓ - No decision about the commit has been made.- 🍒 - The commit has been cherry picked.- ⏩ - The commit has been skipped.- 💡 - The commit has been skipped, but should be ported to Forgejo.- ✍️ - The commit has been skipped, and a port to Forgejo already exists.## Commits- 🍒 [`gitea`](go-gitea/gitea@17cfae8) -> [`forgejo`](https://codeberg.org/forgejo/forgejo/commit/6397da88d30de0a470dabadb8e27fbb202d75458) Hide href attribute of a tag if there is no target_url ([gitea#34556](go-gitea/gitea#34556))- 🍒 [`gitea`](go-gitea/gitea@b408bf2) -> [`forgejo`](https://codeberg.org/forgejo/forgejo/commit/46bc899d57515fc5349e9113e92da2e4b0d93c75) Fix: skip paths check on tag push events in workflows ([gitea#34602](go-gitea/gitea#34602))- 🍒 [`gitea`](go-gitea/gitea@9165ea8) -> [`forgejo`](https://codeberg.org/forgejo/forgejo/commit/04332f31bfd8a1c0e8676e4764d44e087f1ccc30) Only activity tab needs heatmap data loading ([gitea#34652](go-gitea/gitea#34652))- 🍒 [`gitea`](go-gitea/gitea@3f7dbbd) -> [`forgejo`](https://codeberg.org/forgejo/forgejo/commit/2a9019fd0491684cdeab6d50a16e5cffaef5508b) Small fix in Pull Requests page ([gitea#34612](go-gitea/gitea#34612))- 🍒 [`gitea`](go-gitea/gitea@497b83b) -> [`forgejo`](https://codeberg.org/forgejo/forgejo/commit/9a83cc7bad79fe79447bf6e3cb3144292f922ebb) Fix migration pull request title too long ([gitea#34577](go-gitea/gitea#34577))## TODO- 💡 [`gitea`](go-gitea/gitea@6b8b580) Refactor container and UI ([gitea#34736](go-gitea/gitea#34736))  Packages: Fix for container, needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@bbee652) Prevent duplicate form submissions when creating forks ([gitea#34714](go-gitea/gitea#34714))  Fork: Fix, needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@d21ce9f) Improve the performance when detecting the file editable ([gitea#34653](go-gitea/gitea#34653))  LFS: Performance improvement - needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@8fed27b) Fix various problems ([gitea#34708](go-gitea/gitea#34708))  Various: Fixes, tests missing.------- 💡 [`gitea`](go-gitea/gitea@c9505a2) Improve instance wide ssh commit signing ([gitea#34341](go-gitea/gitea#34341))  CodeSign: Nice feature - needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@fbc3796) Fix pull requests API convert panic when head repository is deleted. ([gitea#34685](go-gitea/gitea#34685))  Pull: Fix, needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@1610a63) Fix commit message rendering and some UI problems ([gitea#34680](go-gitea/gitea#34680))  Various Fixes - needs carefull merge.------- 💡 [`gitea`](go-gitea/gitea@0082cb5) Fix last admin check when syncing users ([gitea#34649](go-gitea/gitea#34649))  oidc: fix "first user is always admin". Needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@c6b2cbd) Fix footnote jump behavior on the issue page. ([gitea#34621](go-gitea/gitea#34621))  Issues: Fix Markdown rendering. Needs carefull merge------- 💡 [`gitea`](go-gitea/gitea@7a59f5a) Ignore "Close" error when uploading container blob ([gitea#34620](go-gitea/gitea#34620))  No issue, no test.------- 💡 [`gitea`](go-gitea/gitea@6d0b240) Keeping consistent between UI and API about combined commit status state and fix some bugs ([gitea#34562](go-gitea/gitea#34562))  Next PR in Commit-Status story.------- 💡 [`gitea`](go-gitea/gitea@f604144) Refactor FindOrgOptions to use enum instead of bool, fix membership visibility ([gitea#34629](go-gitea/gitea#34629))  Just for a common sense here: How should I consider refactorings?------- 💡 [`gitea`](go-gitea/gitea@cc942e2) Fix GetUsersByEmails ([gitea#34643](go-gitea/gitea#34643))  User: Seems to fix email validation - but seems not to be finished.------- 💡 [`gitea`](go-gitea/gitea@7fa5a88) Add `--color-logo` for text that should match logo color ([gitea#34639](go-gitea/gitea#34639))  UI: Nice idea - can we adapt this?------- 💡 [`gitea`](go-gitea/gitea@47d69b7) Validate hex colors when creating/editing labels ([gitea#34623](go-gitea/gitea#34623))  Label: Color validation but needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@108db0b) Fix possible pull request broken when leave the page immediately after clicking the update button ([gitea#34509](go-gitea/gitea#34509))  Nice fix for a bug hard to trace down.  Needs careful merge & think about whether a test is possible.------- 💡 [`gitea`](go-gitea/gitea@79cc369) Fix issue label delete incorrect labels webhook payload ([gitea#34575](go-gitea/gitea#34575))  Small fix but would expect a test, showing what was fixed.------- 💡 [`gitea`](go-gitea/gitea@fe57ee3) fixed incorrect page navigation with up and down arrow on last item of dashboard repos ([gitea#34570](go-gitea/gitea#34570))  Small & simple - but tests are missing.------- 💡 [`gitea`](go-gitea/gitea@4e47148) Remove unnecessary duplicate code ([gitea#34552](go-gitea/gitea#34552))  Fix arround "Split GetLatestCommitStatus".------- 💡 [`gitea`](go-gitea/gitea@c5e78fc) Do not mutate incoming options to SearchRepositoryByName ([gitea#34553](go-gitea/gitea#34553))  Large refactoring to simplify options handling. But needs careful merge.------- 💡 [`gitea`](go-gitea/gitea@f48c013) Fix/improve avatar sync from LDAP ([gitea#34573](go-gitea/gitea#34573))  Nice fix but needs test.------- 💡 [`gitea`](go-gitea/gitea@e8d8984) Fix some trivial problems ([gitea#34579](go-gitea/gitea#34579))  Various fixes, tests missing.------## Skipped- ⏩ [`gitea`](go-gitea/gitea@637070e) Fix container range bug ([gitea#34725](go-gitea/gitea#34725))------- ⏩ [`gitea`](go-gitea/gitea@0d3e995) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@28debdb) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@dcc9206) Raise minimum Node.js version to 20, test on 24 ([gitea#34713](go-gitea/gitea#34713))------- ⏩ [`gitea`](go-gitea/gitea@bc28654) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@65986f4) Refactor embedded assets and drop unnecessary dependencies ([gitea#34692](go-gitea/gitea#34692))------- ⏩ [`gitea`](go-gitea/gitea@18bafcc) Bump minimum go version to 1.24.4 ([gitea#34699](go-gitea/gitea#34699))------- ⏩ [`gitea`](go-gitea/gitea@8d135ef) Update JS deps ([gitea#34701](go-gitea/gitea#34701))------- ⏩ [`gitea`](go-gitea/gitea@d5893ee) Fix markdown wrap ([gitea#34697](go-gitea/gitea#34697))  - gitea UI specific specific------- ⏩ [`gitea`](go-gitea/gitea@06ccb3a) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@94db956) frontport changelog ([gitea#34689](go-gitea/gitea#34689))------- ⏩ [`gitea`](go-gitea/gitea@d5afdcc) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@e9f5105) Migrate to urfave v3 ([gitea#34510](go-gitea/gitea#34510))  already in Forgejo - seehttps://codeberg.org/forgejo/forgejo/pulls/8035------- ⏩ [`gitea`](go-gitea/gitea@2c341b6) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@92e7e98) Update x/crypto package and make builtin SSH use default parameters ([gitea#34667](go-gitea/gitea#34667))------- ⏩ [`gitea`](go-gitea/gitea@7b39c82) Fix "oras" OCI client compatibility ([gitea#34666](go-gitea/gitea#34666))  Already in forgejo - seehttps://codeberg.org/forgejo/forgejo/issues/8070------- ⏩ [`gitea`](go-gitea/gitea@1fe652c) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@a9a705f) Fix missed merge commit sha and time when migrating from codecommit ([gitea#34645](go-gitea/gitea#34645))  Migration: Seems to be an important fix, but no tests.  As I know@earl-warren worked hard on migration, is this still relevant to us?------- ⏩ [`gitea`](go-gitea/gitea@1e0758a) [skip ci] Updated translations via Crowdin------- ⏩ [`gitea`](go-gitea/gitea@f6f6aed) Update JS deps, regenerate SVGs ([gitea#34640](go-gitea/gitea#34640))------- ⏩ [`gitea`](go-gitea/gitea@aa2b3b2) Misc CSS fixes ([gitea#34638](go-gitea/gitea#34638))  - gitea UI specific specific------- ⏩ [`gitea`](go-gitea/gitea@b38f2d3) add codecommit to supported services in api docs ([gitea#34626](go-gitea/gitea#34626))------- ⏩ [`gitea`](go-gitea/gitea@74a0178) add openssh-keygen to rootless image ([gitea#34625](go-gitea/gitea#34625))  already in Forgejo - seehttps://codeberg.org/forgejo/forgejo/issues/6896------- ⏩ [`gitea`](go-gitea/gitea@5b22af4) bump to alpine 3.22 ([gitea#34613](go-gitea/gitea#34613))------- ⏩ [`gitea`](go-gitea/gitea@9e0e107) Fix notification count positioning for variable-width elements ([gitea#34597](go-gitea/gitea#34597))  - gitea UI specific specific------- ⏩ [`gitea`](go-gitea/gitea@e5781ce) Fix margin issue in markup paragraph rendering ([gitea#34599](go-gitea/gitea#34599))  - gitea UI specific specific------- ⏩ [`gitea`](go-gitea/gitea@375dab1) Make pull request and issue history more compact ([gitea#34588](go-gitea/gitea#34588))  - gitea UI specific specific------- ⏩ [`gitea`](go-gitea/gitea@2a1585b) Refactor some tests ([gitea#34580](go-gitea/gitea#34580))------<details><summary><h2>Stats</h2></summary><br>Between [`gitea@d5bbaee64e`](go-gitea/gitea@d5bbaee) and [`gitea@6b8b580218`](go-gitea/gitea@6b8b580), **55** commits have been reviewed. We picked **5**, skipped **28** (of which **3** were already in Forgejo!), and decided to port **22**.</details>Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>Co-authored-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com>Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>Co-authored-by: endo0911engineer <161911062+endo0911engineer@users.noreply.github.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>Reviewed-on:https://codeberg.org/forgejo/forgejo/pulls/8198Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>Co-authored-by: Michael Jerger <michael.jerger@meissa-gmbh.de>Co-committed-by: Michael Jerger <michael.jerger@meissa-gmbh.de>
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

Assignees

No one assigned

Labels

backport/doneAll backports for this PR have been createdbackport/v1.24This PR should be backported to Gitea 1.24lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/frontendmodifies/goPull requests that update Go codetype/bug

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

Navigation to footnote fragment throws JS error Footnote References Not Properly Scoped to Individual Comments

4 participants

@charles7668@lunny@wxiaoguang@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp