Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Replace update repository function in some places#34566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 9 commits intogo-gitea:mainfromlunny:lunny/extract_update_repository
Jun 17, 2025

Conversation

@lunny
Copy link
Member

@lunnylunny commentedMay 30, 2025
edited
Loading

UpdateAllCols is dangerous, the columns should be updated when necessary.

This PR replaces someupdateRepository invokes to reduce possible problems and wrongly updated time. Some parts have been fixed in#34388, but some are hidden in the functionupdateRepository. Alternatively, usingUpdateRepositoryColsNoAutoTime to update the changed columns.

SomeUpdateRepoSize invokes are duplicated, so they will be removed when extracting fromupdateRepository.

PS: I suspect#27472 is related. Thenum_pulls is not right in the database.

@lunnylunny added the type/refactoringExisting code has been cleaned up. There should be no new functionality. labelMay 30, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelMay 30, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelMay 30, 2025
@lunnylunny marked this pull request as ready for reviewMay 30, 2025 20:37
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 9, 2025
@yp05327yp05327 changed the titlereplace update repository function in some placesReplace update repository function in some placesJun 10, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJun 17, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 17, 2025
@lunnylunny merged commit224aa64 intogo-gitea:mainJun 17, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.25.0 milestoneJun 17, 2025
@lunnylunny deleted the lunny/extract_update_repository branchJune 17, 2025 16:54
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 17, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJun 18, 2025
* giteaofficial/main:  Remove unused param `doer` (go-gitea#34545)  Improve alignment of commit status icon on commit page (go-gitea#34750)  Run `gopls modernize` on codebase (go-gitea#34751)  Refactor some file edit related code (go-gitea#34744)  [skip ci] Updated translations via Crowdin  Fix ghost user in feeds when pushing in an actions, it should be gitea-actions (go-gitea#34703)  upgrade orgmode to v1.8.0 (go-gitea#34721)  Support title and body query parameters for new PRs (go-gitea#34537)  Improve nuget/rubygems package registries (go-gitea#34741)  Replace update repository function in some places (go-gitea#34566)  remove unnecessary duplicate code (go-gitea#34733)  fix: prevent double markdown link brackets when pasting URL (go-gitea#34745)  Fix JS error for "select" dropdown (go-gitea#34743)  [skip ci] Updated translations via Crowdin  Allow renaming/moving binary/LFS files in the UI (go-gitea#34350)  Clean bindata (go-gitea#34728)  Refactor container and UI (go-gitea#34736)  Prevent duplicate form submissions when creating forks (go-gitea#34714)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@yp05327yp05327yp05327 approved these changes

+1 more reviewer

@appleboyappleboyappleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/refactoringExisting code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny@appleboy@yp05327@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp