Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add post-installation redirect based on admin account status#34493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 17 commits intogo-gitea:mainfromkerwin612:feat/redirect-after-install
Jun 21, 2025

Conversation

@kerwin612
Copy link
Member

This PR adds a feature to direct users to appropriate pages after system installation:

  • If no admin credentials were provided during installation, redirect to the registration page with a prominent notice about creating the first administrative account
  • If admin credentials were already set, redirect directly to the login page

4d396ad132d9b57fc4f45a62117177f1

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelMay 17, 2025
@github-actionsgithub-actionsbot added modifies/translation modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/frontend labelsMay 17, 2025
@kerwin612kerwin612 requested a review froma teamJune 1, 2025 05:29
Copy link
Member

@kemzebkemzeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can't speak on frontend design, but otherwise this looks good to me.

Was iffy about theHasUsers() calls ignoring DB errors, but after further reading it seems the worst that can happen is:

  • User accesses sign up page (or completes the install config if they're on the install page)
  • A DB error occurs
  • Server sends sign up page + thesign_up_tip message to the user

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 7, 2025
Copy link
Member

@denyskondenyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJun 8, 2025
@denyskondenyskon added type/enhancementAn improvement of existing functionality topic/ui-interactionChange the process how users use Gitea instead of the visual appearance labelsJun 8, 2025
@wxiaoguang
Copy link
Contributor

And also please review admin related bug fix: Fix last admin check when syncing users#34649

@lunnylunny added this to the1.25.0 milestoneJun 20, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 20, 2025
@lunnylunnyenabled auto-merge (squash)June 21, 2025 18:31
@lunnylunny merged commit0548c10 intogo-gitea:mainJun 21, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJun 21, 2025
@kerwin612kerwin612 deleted the feat/redirect-after-install branchJune 23, 2025 01:59
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJun 23, 2025
* giteaofficial/main: (22 commits)  [skip ci] Updated translations via Crowdin  Fix required contexts and commit status matching bug (go-gitea#34815)  Add "Cancel workflow run" button to Actions list page (go-gitea#34817)  Use `shallowRef` instead of `ref` in `.vue` files where possible (go-gitea#34813)  Edit file workflow for creating a fork and proposing changes (go-gitea#34240)  Refactor packages (go-gitea#34777)  Refactor wiki (go-gitea#34805)  [skip ci] Updated translations via Crowdin  Upgrade htmx to 2.0.5 (go-gitea#34809)  Forks repository list page follow other repositories page (go-gitea#34784)  Add post-installation redirect based on admin account status (go-gitea#34493)  Rework delete org and rename org UI (go-gitea#34762)  Refactor editor (go-gitea#34780)  Improve img lazy loading (go-gitea#34804)  [skip ci] Updated translations via Crowdin  Fix Feishu webhook signature verification (go-gitea#34788)  Upgrade chi to v5.2.2 (go-gitea#34798)  Fix the issue of abnormal interface when there is no issue-item on the project page (go-gitea#34791)  Fix container range bug (go-gitea#34795)  Fix OCI manifest parser (go-gitea#34797)  ...
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny left review comments

@wxiaoguangwxiaoguangwxiaoguang left review comments

@ChristopherHXChristopherHXChristopherHX left review comments

@denyskondenyskondenyskon approved these changes

+2 more reviewers

@BLumiaBLumiaBLumia approved these changes

@kemzebkemzebkemzeb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/frontendmodifies/goPull requests that update Go codemodifies/templatesThis PR modifies the template filesmodifies/translationtopic/ui-interactionChange the process how users use Gitea instead of the visual appearancetype/enhancementAn improvement of existing functionality

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

8 participants

@kerwin612@wxiaoguang@lunny@BLumia@ChristopherHX@denyskon@kemzeb@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp