Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Allow renaming/moving binary/LFS files in the UI#34350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 41 commits intogo-gitea:mainfrombytedream:non-text-edit
Jun 17, 2025

Conversation

@bytedream
Copy link
Contributor

@bytedreambytedream commentedMay 2, 2025•
edited
Loading

Adds the ability to rename/move binary files like binary blobs or images and files that are too large in the web ui.
This was purposed in#24722, along with the ability edit images via an upload of a new image, which I didn't implement here (could be done in a separate PR).

Binary file content:
binary

File too large:
toolarge

GitHub does the same (I've copied the text from there):
gh

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelMay 2, 2025
@github-actionsgithub-actionsbot added modifies/translation modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files labelsMay 2, 2025
@lunnylunny added this to the1.25.0 milestoneMay 3, 2025
@lunny
Copy link
Member

Could you also have a screenshot for editing text files stored in LFS and binary files stored in LFS?

@bytedream
Copy link
ContributorAuthor

bytedream commentedMay 3, 2025•
edited
Loading

I'm working on adding support for LFS (I thought it'd behave the same as non LFS files), and noticed that atm LFS files can be edited directly on the web ui if the file path is manually set in the URL.

(this actually is a 20MB binary file stored in LFS)
Screenshot_20250503_035508

This behavior/bug will be removed in this PR, but as it's scheduled for version 1.25, it will be present in 1.24. Should I do a separate PR that fixes this for 1.24 backporting (@lunny)?

@lunny
Copy link
Member

I'm working on adding support for LFS (I thought it'd behave the same as non LFS files), and noticed that atm LFS files can be edited directly on the web ui if the file path is manually set in the URL.

(this actually is a 20MB binary file stored in LFS)Screenshot_20250503_035508

This behavior/bug will be removed in this PR, but as it's scheduled for version 1.25, it will be present in 1.24. Should I do a separate PR that fixes this for 1.24 backporting (@lunny)?

I think the bug fix cannot be backport easily to v1.24 if the PR is complex. But maybe we can try. Please send another PR to fix the bug.

bytedream reacted with thumbs up emoji

@bytedreambytedream changed the titleRename/move binary files in Web UIWIP: Rename/move binary files in Web UIMay 5, 2025
@lunnylunny removed the backport/v1.24This PR should be backported to Gitea 1.24 labelMay 28, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsMay 28, 2025
@lunny
Copy link
Member

last call @go-gitea/technical-oversight-committee

@github-actionsgithub-actionsbot added modifies/apiThis PR adds API routes or modifies them modifies/cliPR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/docs modifies/internal modifies/dependencies docs-update-neededThe document needs to be updated synchronously labelsJun 13, 2025
@github-actionsgithub-actionsbot removed modifies/apiThis PR adds API routes or modifies them modifies/cliPR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/docs modifies/internal modifies/dependencies docs-update-neededThe document needs to be updated synchronously labelsJun 13, 2025
@delvhdelvh changed the titleRename/move binary and LFS files in web UIAllow renaming/moving binary/LFS files in the UIJun 16, 2025
@lunnylunny merged commit3a37d63 intogo-gitea:mainJun 17, 2025
25 of 26 checks passed
@wxiaoguang
Copy link
Contributor

wxiaoguang commentedJun 17, 2025•
edited
Loading

Thank you very much for the feature.

I found something I don't understand, could you take a look at "Refactor some file edit related code#34744"?

(I also updated some comments and removed some unnecessary type-casting code, and merged some common code)

bytedream reacted with thumbs up emoji

wxiaoguang added a commit that referenced this pull requestJun 18, 2025
Follow up#34350---------Co-authored-by: delvh <dev.lh@web.de>
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJun 18, 2025
* giteaofficial/main:  Remove unused param `doer` (go-gitea#34545)  Improve alignment of commit status icon on commit page (go-gitea#34750)  Run `gopls modernize` on codebase (go-gitea#34751)  Refactor some file edit related code (go-gitea#34744)  [skip ci] Updated translations via Crowdin  Fix ghost user in feeds when pushing in an actions, it should be gitea-actions (go-gitea#34703)  upgrade orgmode to v1.8.0 (go-gitea#34721)  Support title and body query parameters for new PRs (go-gitea#34537)  Improve nuget/rubygems package registries (go-gitea#34741)  Replace update repository function in some places (go-gitea#34566)  remove unnecessary duplicate code (go-gitea#34733)  fix: prevent double markdown link brackets when pasting URL (go-gitea#34745)  Fix JS error for "select" dropdown (go-gitea#34743)  [skip ci] Updated translations via Crowdin  Allow renaming/moving binary/LFS files in the UI (go-gitea#34350)  Clean bindata (go-gitea#34728)  Refactor container and UI (go-gitea#34736)  Prevent duplicate form submissions when creating forks (go-gitea#34714)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wxiaoguangwxiaoguangwxiaoguang left review comments

@lunnylunnylunny approved these changes

Assignees

No one assigned

Labels

lgtm/need 1This PR needs approval from one additional maintainer to be merged.modifies/frontendmodifies/goPull requests that update Go codemodifies/templatesThis PR modifies the template filesmodifies/translation

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bytedream@lunny@wxiaoguang@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp