Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use run-name and evaluate workflow variables#34301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 40 commits intogo-gitea:mainfrombadhezi:dev/hezi/fix-run-name
May 20, 2025

Conversation

@badhezi
Copy link
Contributor

@badhezibadhezi commentedApr 28, 2025•
edited
Loading

This addresses#34247
depends onhttps://gitea.com/gitea/act/pulls/137

I couldn't find any previous implementation forrun-name support on workflows so I created one.

Key points:
All dispatched workflows, scheduled workflows and detected workflows (from different hooks) will use and evaluaterun-name if exists, with the corresponding gitea context and variables. This will be used as the Action run title and replace the default commit message being used today.

Had to change act package jobparser (see link above)
and create two helpers

func (s*ActionSchedule)ToActionRun()*ActionRun {

and
func (g*GiteaContext)ToGitHubContext()*model.GithubContext {

to pass the correct types toGenerateGiteaContext andWithGitContext respectively.

Screenshot 2025-04-28 at 17 13 01

Zettat123 reacted with thumbs up emoji
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelApr 28, 2025
@github-actionsgithub-actionsbot added modifies/goPull requests that update Go code modifies/frontend labelsApr 28, 2025
@badhezibadhezi changed the titleDev/hezi/fix run nameUse run-name and evaluate workflow variablesApr 28, 2025
@TheFox0x7
Copy link
Contributor

Shouldn't this go tojobparser?

badhezi reacted with thumbs up emoji

@badhezi
Copy link
ContributorAuthor

@TheFox0x7
Createdhttps://gitea.com/gitea/act/pulls/136 to move most of the logic to jobparser

@badhezibadheziforce-pushed thedev/hezi/fix-run-name branch fromcca335d to9408c76CompareApril 29, 2025 12:17
@badhezi
Copy link
ContributorAuthor

Hey@lunny you think I can get someone to reviewhttps://gitea.com/gitea/act/pulls/137 so we can push this forward?
Thanks.

@lunny
Copy link
Member

lunny commentedMay 12, 2025•
edited
Loading

Hey@lunny you think I can get someone to reviewhttps://gitea.com/gitea/act/pulls/137 so we can push this forward? Thanks.

That PR merged.

badhezi reacted with heart emoji

@badhezi
Copy link
ContributorAuthor

Hey@lunny you think I can get someone to reviewhttps://gitea.com/gitea/act/pulls/137 so we can push this forward? Thanks.

That PR merged.

Thanks@lunny
Should I want for a new tag release of gitea/act or is there anything else to do?

@lunny
Copy link
Member

Hey@lunny you think I can get someone to reviewhttps://gitea.com/gitea/act/pulls/137 so we can push this forward? Thanks.

That PR merged.

Thanks@lunny Should I want for a new tag release of gitea/act or is there anything else to do?

v0.261.6 tagged.

badhezi reacted with heart emoji

@badhezi
Copy link
ContributorAuthor

badhezi commentedMay 13, 2025•
edited
Loading

Can this PR please be reviewed?
@wxiaoguang@lunny
Thanks

@lunnylunny added this to the1.25.0 milestoneMay 13, 2025
@badhezibadhezi requested a review fromZettat123May 16, 2025 22:03
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsMay 17, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsMay 18, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelMay 19, 2025
@lunnylunnyenabled auto-merge (squash)May 20, 2025 02:02
@lunnylunny merged commit0534edd intogo-gitea:mainMay 20, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelMay 20, 2025
@lunnylunny mentioned this pull requestMay 20, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestMay 21, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Fix ephemeral runner deletion (go-gitea#34447)  ui: add a default tab on repo header when migrating (go-gitea#34503)  Use run-name and evaluate workflow variables (go-gitea#34301)  feat(api): add date range filtering to commit retrieval endpoints (go-gitea#34497)  Export repo's manual merge settings (go-gitea#34502)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsAug 18, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang left review comments

+1 more reviewer

@Zettat123Zettat123Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/dependenciesmodifies/goPull requests that update Go code

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

6 participants

@badhezi@TheFox0x7@lunny@wxiaoguang@Zettat123@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp