NotificationsYou must be signed in to change notification settings
Fork6.3k
Star52.6k

Auto expand "New PR" form#33971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

wxiaoguang merged 4 commits intogo-gitea:mainfromwxiaoguang:fix-pr-form

Mar 24, 2025

Merged

Auto expand "New PR" form#33971

wxiaoguang merged 4 commits intogo-gitea:mainfromwxiaoguang:fix-pr-form

Mar 24, 2025

Conversation

Copy link

Contributor

wxiaoguang commentedMar 22, 2025•
edited
Loading

Follow GitHub's behavior: use?expand=1 to expand the "New PR" form

The old.Flash check is not needed anymore because now we use "fetch action form", no flash message.

fix

2db933d

GiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. label

Mar 22, 2025

pull-request-sizebot added the size/M label

Mar 22, 2025

github-actionsbot added modifies/go

Pull requests that update Go code

modifies/templatesThis PR modifies the template files labels

Mar 22, 2025

Copy link

ContributorAuthor

wxiaoguang commentedMar 22, 2025

wxiaoguang mentioned this pull request

Mar 22, 2025

Open to Pull Request form directly on compare page#30217

Closed

wxiaoguang added the type/enhancementAn improvement of existing functionality label

Mar 22, 2025

wxiaoguang added this to the1.24.0 milestone

Mar 22, 2025

Copy link

Member

silverwind commentedMar 22, 2025•
edited
Loading

Will this also work for the links that are output when pushing to a new branch over SSH? GitHub uses a special URL scheme likerepo/pulls/new/branch which redirects to a auto-expanded compare page. I think it's using a ?-less URL so its easier to copy from terminal.

I would strongly prefer if we have that URL too and it could be used for this "Open PR" button.

Copy link

ContributorAuthor

wxiaoguang commentedMar 22, 2025

Will this also work for the links that are output when pushing to a new branch over SSH?

I do not know where it is (I don't use it).

So feel free to add it in this PR or improve it in the future.

lunny approved these changes

Mar 22, 2025

View reviewed changes

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

Mar 22, 2025

Copy link

Member

silverwind commentedMar 24, 2025•
edited
Loading

Will this also work for the links that are output when pushing to a new branch over SSH?
I do not know where it is (I don't use it).
So feel free to add it in this PR or improve it in the future.

It's the message that shows for the first time when pushing to a branch:

$ git checkout -b testbranch 'test' set up to track 'master' by rebasing.Switched to a new branch 'test'$ git commit --allow-empty -m 'test'[test 3bbb14a] test$ git push origin testEnumerating objects: 1, done.Counting objects: 100% (1/1), done.Writing objects: 100% (1/1), 367 bytes | 183.00 KiB/s, done.Total 1 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)remote:remote: Create a new pull request for 'test':remote:   https://gitea.com/org/repo/compare/master...test  <----remote:remote: . Processing 1 referencesremote: Processed 1 references in totalTo gitea.com:org/repo.git * [new branch]      test -> test

Copy link

Member

silverwind commentedMar 24, 2025•
edited
Loading

FYI, here is the same link that GitHub produces:

remote:remote: Create a pull request for 'test2' on GitHub by visiting:remote:      https://github.com/silverwind/gitea/pull/new/test2remote:

When opening the linkhttps://github.com/silverwind/gitea/pull/new/test2, it redirects tohttps://github.com/go-gitea/gitea/compare/main...silverwind:gitea:test2?expand=1, e.g. the expanded compare page.

fix

f1b1264

pull-request-sizebot added size/L and removed size/M labels

Mar 24, 2025

Copy link

ContributorAuthor

wxiaoguang commentedMar 24, 2025

When opening the linkhttps://github.com/silverwind/gitea/pull/new/test2, it redirects tohttps://github.com/go-gitea/gitea/compare/main...silverwind:gitea:test2?expand=1, e.g. the expanded compare page.

f1b1264

fix

cf1949c

wxiaoguang force-pushed thefix-pr-form branch fromdf28cf7 tocf1949cCompare

March 24, 2025 11:45

silverwind approved these changes

Mar 24, 2025

View reviewed changes

Copy link

Member

silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome work, thanks

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

Mar 24, 2025

Merge branch 'main' into fix-pr-form

145a65d

wxiaoguangenabled auto-merge (squash)

March 24, 2025 14:05

wxiaoguang merged commitb1e326d intogo-gitea:main

Mar 24, 2025

26 checks passed

wxiaoguang deleted the fix-pr-form branch

March 24, 2025 14:31

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Mar 26, 2025

Merge remote-tracking branch 'giteaofficial/main'

6d8eaa4

* giteaofficial/main:  Enable color output in govulncheck (go-gitea#34012)  Update Makefile test comments (go-gitea#34013)  Move duplicated functions (go-gitea#33977)  Git client will follow 301 but 307 (go-gitea#34005)  Prepare common tmpl functions in a middleware (go-gitea#33957)  Update go mod dependencies (go-gitea#33988)  Fix some migration and repo name problems (go-gitea#33986)  [skip ci] Updated translations via Crowdin  Use filepath.Join instead of path.Join for file system file operations (go-gitea#33978)  Add changelog for 1.23.6 (go-gitea#33975)  Fix incorrect code search indexer options (go-gitea#33992)  Auto expand "New PR" form (go-gitea#33971)  Move ParseBool to optional (go-gitea#33979)