Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add workflow_run api + webhook#33964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wxiaoguang merged 82 commits intogo-gitea:mainfromChristopherHX:workflow-webhook-api
Jun 20, 2025

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHXChristopherHX commentedMar 21, 2025•
edited
Loading

Implements

Fixes

  • workflow_job webhook url to no longer contain theruns/<run> part to align with api
  • workflow instance does now use it's name inside the file instead of filename if set

Refactoring

  • Moved a lot of logic from workflows/workflow_job into a shared module used by both webhook and api

TODO

  • Verify Keda Compatibility
  • Edit Webhook API bug is resolved

Closes#23670
Closes#23796
Closes#24898
Replaces#28047 and is much more complete

lunny, fidarit, maxsargentdev, Makonike, and merlinz01 reacted with thumbs up emoji
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelMar 21, 2025
@github-actionsgithub-actionsbot added modifies/translation modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code labelsMar 21, 2025
@ChristopherHX
Copy link
ContributorAuthor

My time to respond or make changes is limited in the next seven days, due to exams.

Other than that, yes I think this is ready for review.

Copy link
Contributor

@wxiaoguangwxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No hurry, overall looks good. Thank you very much.

(Maybe will take a look again later)

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJun 19, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJun 20, 2025
Copy link
Contributor

@wxiaoguangwxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Did another round review. I think it looks good to me.

Is there anything else to change? If no, let's merge ~~ 🙏

@ChristopherHX
Copy link
ContributorAuthor

Is there anything else to change?

Nothing that I am aware of, I agree with merging this now. Then I can polish the keda scaler side of things soon and move that one out of a draft.

wxiaoguang, Makonike, and merlinz01 reacted with thumbs up emojiwxiaoguang reacted with heart emojiMakonike reacted with rocket emoji

@wxiaoguangwxiaoguang merged commitcda90ec intogo-gitea:mainJun 20, 2025
26 checks passed
bdruth added a commit to bdruth/gitea that referenced this pull requestJun 28, 2025
Implements additional query parameters for the workflow runs API to match GitHub's REST API specification.- Add `exclude_pull_requests` query parameter- Add `check_suite_id` parameter- Add `created` parameter with date range and comparison support- Add workflow-specific endpoint `/repos/{owner}/{repo}/actions/workflows/{workflow_id}/runs`Builds on the workflow API foundation fromgo-gitea#33964 to provide additional GitHub API compatibility.Reference:https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#list-workflow-runs-for-a-workflow
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsSep 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/apiThis PR adds API routes or modifies themmodifies/goPull requests that update Go codemodifies/templatesThis PR modifies the template filesmodifies/translation

Projects

None yet

Milestone

1.25.0

Development

Successfully merging this pull request may close these issues.

workflow_run for action trigger event Webhook trigger for actions (CI) Implement workflow_* webhook event

5 participants

@ChristopherHX@wxiaoguang@lunny@techknowlogick@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp