Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Refactor admin/common.ts#33788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Refactor admin/common.ts#33788
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
wxiaoguang commentedMar 4, 2025
Diff by ignoring spaces:https://github.com/go-gitea/gitea/pull/33788/files?diff=split&w=1 Manually tested:
|
delvh approved these changesMar 4, 2025
lunny approved these changesMar 4, 2025
163bbca intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
zjjhot added a commit to zjjhot/gitea that referenced this pull requestMar 5, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Upgrade golang net from 0.35.0 -> 0.36.0 (go-gitea#33795) Remove context from git struct (go-gitea#33793) Small refactor to reduce unnecessary database queries and remove duplicated functions (go-gitea#33779) Refactor repo-issue.ts (go-gitea#33784) Refactor repo-settings.ts (go-gitea#33785) Refactor admin/common.ts (go-gitea#33788)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontendtype/refactoringExisting code has been cleaned up. There should be no new functionality.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only remove jQuery
Legacy code is still quite unclear, but I don't have time to do a full rewritting, so keep it as-is at the moment.