Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Show info about maintainers are allowed to edit a PR#33738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 2 commits intogo-gitea:mainfromwxiaoguang:fix-show-maintainer-edit
Feb 27, 2025

Conversation

@wxiaoguang
Copy link
Contributor

A simple and clear approach. The existing test TestPullCompare_EnableAllowEditsFromMaintainer should be good enough.

Fix#21280

image

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelFeb 27, 2025
@wxiaoguangwxiaoguang added the type/enhancementAn improvement of existing functionality labelFeb 27, 2025
@wxiaoguangwxiaoguang added this to the1.24.0 milestoneFeb 27, 2025
@kuraga
Copy link

Thanks!

Will it showwhere to push?

@github-actionsgithub-actionsbot added the modifies/templatesThis PR modifies the template files labelFeb 27, 2025
@wxiaoguang
Copy link
ContributorAuthor

Branch info is in the PR description

image

@kuraga
Copy link

As I remember, it's for the author only...
It might bepull/{PR_id} or similar...
Hm. Ok, I can be incorrect.

@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsFeb 27, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsFeb 27, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelFeb 27, 2025
@lunnylunnyenabled auto-merge (squash)February 27, 2025 16:02
@lunnylunny merged commit01156f9 intogo-gitea:mainFeb 27, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelFeb 27, 2025
@wxiaoguangwxiaoguang deleted the fix-show-maintainer-edit branchFebruary 27, 2025 16:52
@kuraga
Copy link

@wxiaoguang ,could you,please make a PR at myhttps://demo.gitea.com/kuraga/test ? WithAllow edits from maintainers on...

zjjhot added a commit to zjjhot/gitea that referenced this pull requestMar 3, 2025
* giteaofficial/main:  Use pullrequestlist instead of []*pullrequest (go-gitea#33765)  Upgrade act to 0.261.4 and actions-proto-go to v0.4.1 (go-gitea#33760)  Webhook add X-Gitea-Hook-Installation-Target-Type Header (go-gitea#33752)  Fix dynamic content loading init problem (go-gitea#33748)  [skip ci] Updated translations via Crowdin  Add composor source field (go-gitea#33502)  upgrade go-crypto from 1.1.5 to 1.1.6 (go-gitea#33745)  Disable go license generation as part of `make tidy` (go-gitea#33747)  Refactor repo-diff.ts (go-gitea#33746)  Use `git diff-tree` for `DiffFileTree` on diff pages (go-gitea#33514)  [skip ci] Updated translations via Crowdin  Improve "generate new access token" form (go-gitea#33730)  Remove superflous tw-content-center (go-gitea#33741)  Clone repository with Tea CLI (go-gitea#33725)  allow filtering /repos/{owner}/{repo}/pulls by target base branch queryparam (go-gitea#33684)  Show info about maintainers are allowed to edit a PR (go-gitea#33738)  Improve admin user view page (go-gitea#33735)  [skip ci] Updated translations via Crowdin  Align sidebar gears to the right (go-gitea#33721)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsMay 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@silverwindsilverwindsilverwind approved these changes

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/templatesThis PR modifies the template filestype/enhancementAn improvement of existing functionality

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

Show info if Maintainers are allowed to edit the Pull

6 participants

@wxiaoguang@kuraga@silverwind@hiifong@lunny@GiteaBot

[8]ページ先頭

©2009-2025 Movatter.jp