Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bump x/oauth2 & x/crypto (#33704)#33727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@techknowlogick
Copy link
Member

Backport dep bump

@GiteaBotGiteaBot added this to the1.23.5 milestoneFeb 26, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelFeb 26, 2025
@techknowlogicktechknowlogick changed the titlebump x/oauth2 & x/cryptobump x/oauth2 & x/crypto (#33704)Feb 26, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsFeb 26, 2025
go1.23
go1.23.0

toolchaingo1.23.6
Copy link
Member

@silverwindsilverwindFeb 26, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't know why go wants to introduce thistoolchain directive and the.0 version here, but it seems like a go bug to me. Seegolang/go#65847 (comment) for my findings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Likely the change itself is bening,toolchain is only a "suggestion" to the go compiler.

@silverwind
Copy link
Member

The build failure seems persistent and odd. It looks as ifgoogle/go-licenses does not create the output directory.go-licenses, but when I try the same locally, it works.

@silverwind
Copy link
Member

Pushed an attempt to fix license build withGOOS=linux.

@silverwind
Copy link
Member

#33747 will fix it, merge this after that one.

Copy link
Member

@silverwindsilverwind left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should be mergeable after#33747 has backported.

@GiteaBotGiteaBot removed the lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelFeb 28, 2025
@GiteaBotGiteaBot added the lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. labelFeb 28, 2025
@techknowlogicktechknowlogick merged commitd634e75 intogo-gitea:release/v1.23Feb 28, 2025
25 of 26 checks passed
@techknowlogicktechknowlogick deleted the go-dep-bump-1.23 branchFebruary 28, 2025 17:46
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsMay 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@silverwindsilverwindsilverwind approved these changes

@delvhdelvhdelvh approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/dependencies

Projects

None yet

Milestone

1.23.5

Development

Successfully merging this pull request may close these issues.

4 participants

@techknowlogick@silverwind@delvh@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp