Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve swagger generation#33664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 6 commits intogo-gitea:mainfromwxiaoguang:fix-swagger-gen
Feb 21, 2025
Merged

Conversation

@wxiaoguang
Copy link
Contributor

Remove most "sed" tricks

@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelFeb 20, 2025
@github-actionsgithub-actionsbot added modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/internal labelsFeb 20, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsFeb 20, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsFeb 20, 2025
@silverwind
Copy link
Member

Also update

[templates/swagger/v1_json.tmpl]
to match the second JSON file.

@ChristopherHX
Copy link
Contributor

Running gopls check...
templates/swagger/v1_json.tmpl:
Wrong line endings or no final newline

1 errors found
exit status 1

This seems to be the additional linter that demands a lf at the end

@silverwind
Copy link
Member

silverwind commentedFeb 20, 2025•
edited
Loading

And update here as well:

- "templates/swagger/v1_json.tmpl"

@wxiaoguang
Copy link
ContributorAuthor

wxiaoguang commentedFeb 21, 2025•
edited
Loading

Also update editorconfig#L18 to match the second JSON file.

No need to change that. By default, "JSON" uses "space". That line is for "tmpl" only.

And update here as well: .github/workflows/files-changed.yml#L87

Done

This seems to be the additional linter that demands a lf at the end

Yep, it's from the editorconfig check. The linters fight with each other .....

Tried to fix the above problems in8d8eac8 , now all linters pass

wxiaoguangand others added2 commitsFebruary 21, 2025 14:56
Co-authored-by: silverwind <me@silverwind.io>
@lunnylunny merged commit4adb7ca intogo-gitea:mainFeb 21, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.24.0 milestoneFeb 21, 2025
@wxiaoguangwxiaoguang deleted the fix-swagger-gen branchFebruary 21, 2025 08:20
zjjhot added a commit to zjjhot/gitea that referenced this pull requestFeb 24, 2025
* giteaofficial/main:  Fix git empty check and HEAD request (go-gitea#33690)  Fix some user name usages (go-gitea#33689)  Try to fix ACME path when renew (go-gitea#33668)  [skip ci] Updated translations via Crowdin  Improve Open-with URL encoding (go-gitea#33666)  Fix for Maven Package Naming Convention Handling (go-gitea#33678)  Improve swagger generation (go-gitea#33664)  Deleting repository should unlink all related packages (go-gitea#33653)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsMay 22, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@silverwindsilverwindsilverwind approved these changes

@delvhdelvhdelvh approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/apiThis PR adds API routes or modifies themmodifies/goPull requests that update Go codemodifies/internalmodifies/templatesThis PR modifies the template files

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

6 participants

@wxiaoguang@silverwind@ChristopherHX@lunny@delvh@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp