Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rework suggestion backend (#33538)#33546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@GiteaBot
Copy link
Collaborator

Backport#33538 by@lunny

Fix#33522

The suggestion backend logic now is

  • If the keyword is empty, returned the latest 5 issues/prs with index desc order
  • If the keyword is digital, find all issues/prs whichindex has a prefix with that, with index asc order
  • If the keyword is non-digital or if the queried records less than 5, searching issues/prs title with alike, with index desc order

Empty keyword

image

Digital

image

Digital and title contains the digital

image

non-Digital

imageimage

Fixgo-gitea#33522 The suggestion backend logic now is- If the keyword is empty, returned the latest 5 issues/prs with indexdesc order- If the keyword is digital, find all issues/prs which `index` has aprefix with that, with index asc order- If the keyword is non-digital or if the queried records less than 5,searching issues/prs title with a `like`, with index desc order## Empty keyword<img width="310" alt="image"src="https://github.com/user-attachments/assets/1912c634-0d98-4eeb-8542-d54240901f77"/>## Digital<img width="479" alt="image"src="https://github.com/user-attachments/assets/0356a936-7110-4a24-b21e-7400201bf9b8"/>## Digital and title contains the digital<img width="363" alt="image"src="https://github.com/user-attachments/assets/6e12f908-28fe-48de-8ccc-09cbeab024d4"/>## non-Digital<img width="435" alt="image"src="https://github.com/user-attachments/assets/2722bb53-baa2-4d67-a224-522a65f73856"/><img width="477" alt="image"src="https://github.com/user-attachments/assets/06708dd9-80d1-4a88-b32b-d29072dd1ba6"/>---------Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@GiteaBotGiteaBot added modifies/goPull requests that update Go code type/bug labelsFeb 10, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelFeb 10, 2025
@GiteaBotGiteaBot added this to the1.23.4 milestoneFeb 10, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsFeb 10, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsFeb 10, 2025
@lunnylunny merged commita014d07 intogo-gitea:release/v1.23Feb 10, 2025
26 checks passed
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsMay 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangAwaiting requested review from wxiaoguang

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lunnylunny

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/bug

Projects

None yet

Milestone

1.23.4

Development

Successfully merging this pull request may close these issues.

3 participants

@GiteaBot@lunny@hiifong

[8]ページ先頭

©2009-2025 Movatter.jp