Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Refactor webhook events#33337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Refactor webhook events#33337
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3847665 to76dc755Comparelunny commentedJan 21, 2025
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
hiifong approved these changesJan 23, 2025
Zettat123 approved these changesJan 23, 2025
e94f37f intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
lunny added a commit that referenced this pull requestFeb 2, 2025
This PR created a mock webhook server in the tests and added integrationtests for generic webhooks.It also fixes bugs in package webhooks and pull request commentwebhooks.This also corrected an error on the package webhook. The previousimplementation uses a `User` struct as an organization, now it has beencorrected but it will not be consistent with the previousimplementation, some fields which not belong to the organization havebeen removed.Backport#33396Backport part of#33337
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/apiThis PR adds API routes or modifies them modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files type/refactoringExisting code has been cleaned up. There should be no new functionality.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract from#33320
This PR uses a map instead of a struct to store webhook event information. It removes many duplicated functions and makes the logic clearer.