Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix commit status events#33320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Fix commit status events#33320
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedJan 20, 2025
lunny added a commit that referenced this pull requestJan 23, 2025
Extract from#33320This PR uses a map instead of a struct to store webhook eventinformation. It removes many duplicated functions and makes the logicclearer.
MemberAuthor
lunny commentedJan 23, 2025
This is ready to review now. |
This was referencedFeb 3, 2025
hiifong approved these changesFeb 4, 2025
wxiaoguang approved these changesFeb 4, 2025
a4676db intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Collaborator
GiteaBot commentedFeb 4, 2025
I was unable to create a backport for 1.23.@lunny, please send one manually. 🍵 |
lunny added a commit to lunny/gitea that referenced this pull requestFeb 4, 2025
Fixgo-gitea#32873Fixgo-gitea#33201~Fixgo-gitea#33244~~Fixgo-gitea#33302~depends on ~go-gitea#33396~A part of this PR should be backported to v1.23 manually.
zjjhot added a commit to zjjhot/gitea that referenced this pull requestFeb 5, 2025
* giteaofficial/main: add `timetzdata` build tag to binary releases (go-gitea#33463) Fix unnecessary comment when moving issue on the same project column (go-gitea#33496) [skip ci] Updated translations via Crowdin Refactor web route handler (go-gitea#33488) Reject star-related requests if stars are disabled (go-gitea#33208) Fix commit status events (go-gitea#33320) [skip ci] Updated translations via Crowdin Disable cron task to update license (go-gitea#33486)
lunny pushed a commit that referenced this pull requestMar 3, 2025
Some visual improvement for the commit status webhook message introducedby#33320- use short commit SHA as already done in e. g. commit webhook- fix spacing, link text- do not set user link for internal gitea-actions userBefore: After:
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestMar 4, 2025
Some visual improvement for the commit status webhook message introducedbygo-gitea#33320- use short commit SHA as already done in e. g. commit webhook- fix spacing, link text- do not set user link for internal gitea-actions userBefore: After:
lunny pushed a commit that referenced this pull requestMar 4, 2025
Backport#33778 by@denyskonSome visual improvement for the commit status webhook message introducedby#33320- use short commit SHA as already done in e. g. commit webhook- fix spacing, link text- do not set user link for internal gitea-actions userBefore: After:Co-authored-by: Denys Konovalov <kontakt@denyskon.de>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
backport/doneAll backports for this PR have been created backport/manualNo power to the bots! Create your backport yourself! lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/translationtype/bug
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix#32873
Fix#33201
Fix#33244Fix#33302depends on
#33396A part of this PR should be backported to v1.23 manually.