Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Refactor ref type#33242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lunny merged 10 commits intogo-gitea:mainfromlunny:lunny/refactor_reftype
Jan 14, 2025
Merged

Refactor ref type#33242

lunny merged 10 commits intogo-gitea:mainfromlunny:lunny/refactor_reftype
Jan 14, 2025

Conversation

@lunny
Copy link
Member

@lunnylunny commentedJan 13, 2025•
edited
Loading

Usegit.RefType instead of a new type definitionRepoRefType oncontext.

I reverted other changes about routers since the router doesn't look beautiful.

@lunnylunny added the type/refactoringExisting code has been cleaned up. There should be no new functionality. labelJan 13, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJan 13, 2025
@github-actionsgithub-actionsbot added modifies/goPull requests that update Go code modifies/templatesThis PR modifies the template files modifies/apiThis PR adds API routes or modifies them modifies/dependencies and removed modifies/templatesThis PR modifies the template files labelsJan 13, 2025
@lunnylunnyforce-pushed thelunny/refactor_reftype branch from068a612 to5399b03CompareJanuary 14, 2025 00:23
@github-actionsgithub-actionsbot removed modifies/apiThis PR adds API routes or modifies them modifies/dependencies labelsJan 14, 2025
@lunnylunny marked this pull request as ready for reviewJanuary 14, 2025 00:27
@wxiaoguang
Copy link
Contributor

There were many abuses in old code (for example:context.RepoRefByTypeOptions{IgnoreNotExistErr: true})

Will do some more fixes.

@wxiaoguangwxiaoguang marked this pull request as draftJanuary 14, 2025 02:09
@wxiaoguangwxiaoguangforce-pushed thelunny/refactor_reftype branch 5 times, most recently from8168888 to1f2ca31CompareJanuary 14, 2025 05:53
@wxiaoguang
Copy link
Contributor

Major changes:

  1. do not sync ".keep" file during tests
  2. fix incorrect route handler and empty repo handling (backported asFix tag route and empty repo #33253 with tests)
  3. do not useRepoRef: most of the calls are abuses.

@wxiaoguangwxiaoguang marked this pull request as ready for reviewJanuary 14, 2025 06:35
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJan 14, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJan 14, 2025
@lunnylunny merged commit6410c34 intogo-gitea:mainJan 14, 2025
26 checks passed
@GiteaBotGiteaBot added this to the1.24.0 milestoneJan 14, 2025
@wxiaoguangwxiaoguang deleted the lunny/refactor_reftype branchJanuary 14, 2025 07:35
@wxiaoguang
Copy link
Contributor

-> Simplify context ref name#33267

zjjhot added a commit to zjjhot/gitea that referenced this pull requestJan 15, 2025
* giteaofficial/main:  [skip ci] Updated translations via Crowdin  Fix some broken route handlers (go-gitea#33268)  Add a confirm dialog for "sync fork" (go-gitea#33270)  Fix sidebar milestone link (go-gitea#33269)  Refactor ref type (go-gitea#33242)  Fix 500 error when error occurred in migration page (go-gitea#33256)  Fix missing license when sync mirror (go-gitea#33255)
lafriks pushed a commit that referenced this pull requestApr 6, 2025
The RepoRef is a no-op since Refactor ref type (#33242) (Jan 14)
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsApr 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wxiaoguangwxiaoguangwxiaoguang approved these changes

+1 more reviewer

@hiifonghiifonghiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/refactoringExisting code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny@wxiaoguang@hiifong@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp