Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Fix editor markdown not incrementing in a numbered list#33187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cd32276 tofd815c8CompareUh oh!
There was an error while loading.Please reload this page.
Contributor
wxiaoguang commentedJan 10, 2025
I will try to make a full fix here, to handle all edge cases including: |
Contributor
wxiaoguang commentedJan 10, 2025
Now most edge cases should have been fixed, and added more tests |
wxiaoguang approved these changesJan 10, 2025
Contributor
wxiaoguang left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
So many edge cases .... I have done my best 🤣
Merged
lunny approved these changesJan 10, 2025
d7ec23f intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull requestJan 10, 2025
Amended the logic for newPrefix in the MarkdownEditor to resolveincorrect number ordering.Fixesgo-gitea#33184Attached screenshot of fixed input similar to issue <img width="175" alt="Screenshot 2025-01-09 at 23 59 24"src="https://github.com/user-attachments/assets/dfa23cf1-f3db-4b5e-99d2-a71bbcb289a8"/>---------Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
lunny pushed a commit that referenced this pull requestJan 10, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJan 14, 2025
* giteaofficial/main: (21 commits) Support public code/issue access for private repositories (go-gitea#33127) Validate that the tag doesn't exist when creating a tag via the web (go-gitea#33241) [skip ci] Updated translations via Crowdin Switch back to `vue-tsc` (go-gitea#33248) Let API create and edit system webhooks, attempt 2 (go-gitea#33180) Fix incorrect ref "blob" (go-gitea#33240) Refactor RefName (go-gitea#33234) Refactor context RefName and RepoAssignment (go-gitea#33226) [skip ci] Updated translations via Crowdin Fix upload file form (go-gitea#33230) Fix mirror bug (go-gitea#33224) Remove unused CSS styles and move some styles to proper files (go-gitea#33217) Refactor context repository (go-gitea#33202) [skip ci] Updated translations via Crowdin Fix unpin hint on the pinned pull requests (go-gitea#33207) fix(cache): cache test triggered by non memory cache (go-gitea#33220) Update README.md (go-gitea#33149) Fix editor markdown not incrementing in a numbered list (go-gitea#33187) Some small refactors (go-gitea#33144) Fix sync fork for consistency (go-gitea#33147) ...
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
backport/doneAll backports for this PR have been created backport/manualNo power to the bots! Create your backport yourself! lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amended the logic for newPrefix in the MarkdownEditor to resolve incorrect number ordering.
Fixes#33184
Attached screenshot of fixed input similar to issue
