Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add missing transaction when set merge#33113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lunny
Copy link
Member

@lunnylunny commentedJan 6, 2025•
edited
Loading

backport from#33079

SetMerged should be in a database transaction otherwise it's possible to have dirty data.

@GiteaBotGiteaBot added this to the1.23.0 milestoneJan 6, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJan 6, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelJan 6, 2025
@lunnylunny added type/bug and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. size/S modifies/goPull requests that update Go code labelsJan 6, 2025
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelJan 6, 2025
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelJan 6, 2025
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsJan 6, 2025
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsJan 6, 2025
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJan 6, 2025
@lunnylunnyenabled auto-merge (squash)January 6, 2025 17:54
@lunnylunny merged commit9899989 intogo-gitea:release/v1.23Jan 6, 2025
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelJan 6, 2025
@lunnylunny deleted the lunny/transaction_setmerge branchJanuary 8, 2025 04:03
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsApr 6, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@wxiaoguangwxiaoguangwxiaoguang approved these changes

+1 more reviewer

@Zettat123Zettat123Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go codetype/bug

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny@wxiaoguang@Zettat123@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp