Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
feat(action): issue change title notifications#33050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+8 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Add `IssueChangeTitle` method to handle issue title changes- Add `notifyIssueChangeWithTitleOrContent` method to generalize notification handling for issue title or content changes- Replace hardcoded `api.HookIssueEdited` with dynamic `action` parameter in notification payloadsSigned-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
lunny approved these changesDec 30, 2024
Zettat123 approved these changesDec 31, 2024
Uh oh!
There was an error while loading.Please reload this page.
Contributor
wxiaoguang commentedDec 31, 2024
And the "action" should be hard-coded to To distinguish them, the proper approach is to use the |
6c89de4 intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
GiteaBot added a commit to GiteaBot/gitea that referenced this pull requestDec 31, 2024
- Add `IssueChangeTitle` method to handle issue title changes- Add `notifyIssueChangeWithTitleOrContent` method to generalizenotification handling for issue title or content changesaction file as below:```yamlname: Semantic Pull Requeston: pull_request_target: types: [edited]```---------Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>Co-authored-by: Giteabot <teabot@gitea.io>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang added a commit that referenced this pull requestDec 31, 2024
Backport#33050 by appleboyaction file as below:```yamlname: Semantic Pull Requeston: pull_request_target: types: [edited]```Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
zjjhot added a commit to zjjhot/gitea that referenced this pull requestJan 2, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin unset XDG_HOME_CONFIG as gitea manages configuration locations (go-gitea#33067) Refactor repo-new.ts (go-gitea#33070) Refactor pull-request compare&create page (go-gitea#33071) feat: link to nuget dependencies (go-gitea#26554) Remove some unnecessary template helpers (go-gitea#33069) Inherit submodules from template repository content (go-gitea#16237) [skip ci] Updated translations via Crowdin feat(action): issue change title notifications (go-gitea#33050) Use project's redirect url instead of composing url (go-gitea#33058) Fix unittest and repo create bug (go-gitea#33061) Fix locale type (go-gitea#33059) Refactor maven package registry (go-gitea#33049) Optimize the installation page (go-gitea#32994) [Feature] Private README.md for organization (go-gitea#32872) Make issue suggestion work for new PR page (go-gitea#33035) Add IntelliJ Gateway's .uuid to gitignore (go-gitea#33052)
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
backport/doneAll backports for this PR have been created lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/goPull requests that update Go code
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IssueChangeTitlemethod to handle issue title changesnotifyIssueChangeWithTitleOrContentmethod to generalize notification handling for issue title or content changesapi.HookIssueEditedwith dynamicactionparameter in notification payloadsaction file as below: