Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Relax the version checking for Arch packages#32908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Contributor
wxiaoguang commentedDec 19, 2024
Instead of testing the invalid ones only, I think it also needs to test the valid ones, especially the bug it fixed in this issue: Made some changes in846a70e |
wxiaoguang approved these changesDec 19, 2024
silverwind approved these changesDec 19, 2024
581e52b intogo-gitea:main 26 checks passed
Uh oh!
There was an error while loading.Please reload this page.
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull requestDec 19, 2024
It is mentioned inhttps://man.archlinux.org/man/PKGBUILD.5: 'Thevariable is not allowed to contain colons, forward slashes, hyphens, orwhitespace.'`_` is also an allowed character, and some software in the Arch LinuxAUR uses this naming convention.---------Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang added a commit that referenced this pull requestDec 19, 2024
Backport#32908 by ExplodingDragonIt is mentioned inhttps://man.archlinux.org/man/PKGBUILD.5: 'Thevariable is not allowed to contain colons, forward slashes, hyphens, orwhitespace.'`_` is also an allowed character, and some software in the Arch LinuxAUR uses this naming convention.Co-authored-by: Exploding Dragon <explodingfkl@gmail.com>Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
backport/doneAll backports for this PR have been created lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. modifies/goPull requests that update Go code type/bug
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is mentioned inhttps://man.archlinux.org/man/PKGBUILD.5: 'The variable is not allowed to contain colons, forward slashes, hyphens, or whitespace.'
_is also an allowed character, and some software in the Arch Linux AUR uses this naming convention.Inlibalpm/package.c#L884-L891, only the prohibited characters are checked.