Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change pprof labels to be prometheus compatible#32865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wxiaoguang merged 5 commits intogo-gitea:mainfromTheFox0x7:change-pprof-label
Dec 18, 2024

Conversation

@TheFox0x7
Copy link
Contributor

Enables scrapping pprof endpoint for continuous profiling

Closes:#32854

There's probably room for improvement - for example droppinggraceful_lifecycle completely and makingwith-hammer intowith: hammer key value (or something similar). But I'd wait with that for a proper spec in OTel so there there won't be a need to align to specn times.

Name is compliant with both prometheus regex andOTel recommendation (but not to their semantic conventions):

For each multi-word dot-delimited component of the attribute name separate the words by underscores (i.e. use snake_case).

Enables scrapping pprof endpoint for continuous profiling
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelDec 16, 2024
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelDec 16, 2024
@lunny
Copy link
Member

Is this a breaking change for those upgraded Gitea instance?

@TheFox0x7
Copy link
ContributorAuthor

It was marked as such in the fork. However the for it to be breaking someone would actively have to scrape the endpoint for (semi-)automated analysis, which I very much doubt anyone is doing (evidence being that no one complained about it).

If you consider that a real possibility then yes, it is breaking.

@lunnylunny added the pr/breakingMerging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labelDec 16, 2024
@lunnylunny added this to the1.24.0 milestoneDec 16, 2024
@lunny
Copy link
Member

The pprof labels was introduced in#19202 and I found there is a grafana mixin introduced in#17758. Maybe this can also be added to grafana mixin in the same PR?

@wxiaoguang
Copy link
Contributor

Maybe this can also be added to grafana mixin in the same PR?

No, there are different, do not mix them at the moment.

@wxiaoguangwxiaoguang removed the pr/breakingMerging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! labelDec 17, 2024
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelsDec 17, 2024
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsDec 17, 2024
@lunnylunny added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelDec 17, 2024
Copy link
Member

@delvhdelvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's measure if it is breaking by whether someone complains 😄

@wxiaoguang
Copy link
Contributor

Let's measure if it is breaking by whether someone complains 😄

Actually it breaks nothing .....

delvh reacted with thumbs up emoji

@wxiaoguangwxiaoguang merged commitb945742 intogo-gitea:mainDec 18, 2024
26 checks passed
@GiteaBotGiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. labelDec 18, 2024
@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsMar 18, 2025
@TheFox0x7TheFox0x7 deleted the change-pprof-label branchOctober 31, 2025 23:13
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

@delvhdelvhdelvh approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/goPull requests that update Go code

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

Change pprof labels to be conformat with prometheus spec

5 participants

@TheFox0x7@lunny@wxiaoguang@delvh@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp