NotificationsYou must be signed in to change notification settings
Fork6.3k
Star52.6k

Fix lfs migration#32812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

techknowlogick merged 4 commits intogo-gitea:mainfromhiifong:fix/lfs-migration

Dec 12, 2024

Merged

Fix lfs migration#32812

techknowlogick merged 4 commits intogo-gitea:mainfromhiifong:fix/lfs-migration

Dec 12, 2024

Conversation

Copy link

Member

hiifong commentedDec 12, 2024

Fix:#32803

Fix lfs migration

9f8d7a9

GiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. label

Dec 12, 2024

pull-request-sizebot added the size/XS label

Dec 12, 2024

github-actionsbot added the modifies/goPull requests that update Go code label

Dec 12, 2024

Merge branch 'main' into fix/lfs-migration

4d6fb0b

lunny added type/bug backport/v1.22 labels

Dec 12, 2024

lunny added this to the1.23.0 milestone

Dec 12, 2024

Copy link

Member

lunny commentedDec 12, 2024

I can confirm this PR fixed the bug. It's better to have some comments on the changed lines and have some tests.

lunny approved these changes

Dec 12, 2024

View reviewed changes

GiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labels

Dec 12, 2024

techknowlogick approved these changes

Dec 12, 2024

View reviewed changes

GiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labels

Dec 12, 2024

techknowlogickenabled auto-merge (squash)

December 12, 2024 20:46

techknowlogick added the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Dec 12, 2024

GiteaBot added2 commits

December 13, 2024 04:47

Merge branch 'main' into fix/lfs-migration

58581b1

Merge branch 'main' into fix/lfs-migration

197314a

delvh approved these changes

Dec 12, 2024

View reviewed changes

techknowlogick merged commit0b8a894 intogo-gitea:main

Dec 12, 2024

26 checks passed

GiteaBot removed the reviewed/wait-mergeThis pull request is part of the merge queue. It will be merged soon. label

Dec 12, 2024

GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request

Dec 13, 2024

Fix lfs migration (go-gitea#32812)

887ee4d

Fix:go-gitea#32803

GiteaBot mentioned this pull request

Dec 13, 2024

Fix lfs migration (#32812)#32818

Merged

GiteaBot added the backport/doneAll backports for this PR have been created label

Dec 13, 2024

zjjhot added a commit to zjjhot/gitea that referenced this pull request

Dec 13, 2024

Merge remote-tracking branch 'giteaofficial/main'

8e00dc0

* giteaofficial/main:  Fix bug of branch/tag selector in the issue sidebar (go-gitea#32744)  Fix lfs migration (go-gitea#32812)  Avoid MacOS keychain dialog in integration tests (go-gitea#32813)  Update actionlint.yaml  Detect whether action view branch was deleted (go-gitea#32764)  Add "n commits" link to contributors in contributors graph page (go-gitea#32799)  Fix "unicode escape" JS error (go-gitea#32806)  use dedicated runners for release artifacts (go-gitea#32811)  Make API "compare" accept commit IDs (go-gitea#32801)  Implement update branch API (go-gitea#32433)  Fix JS error when dropping a file to a editor without dropzone (go-gitea#32804)  chore: use errors.New to replace fmt.Errorf with no parameters (go-gitea#32800)

lunny pushed a commit that referenced this pull request

Dec 13, 2024

Fix lfs migration (#32812) (#32818)

e7de2fc

Backport#32812 by@hiifongFix:#32803![image](https://github.com/user-attachments/assets/3ea1f4e0-e26f-4a15-957e-dd6caf91deb1)![image](https://github.com/user-attachments/assets/44b99624-c347-4f2d-a11c-13ec1276eea2)Co-authored-by: hiifong <i@hiif.ong>

Copy link

MemberAuthor

hiifong commentedDec 13, 2024

I can confirm this PR fixed the bug. It's better to have some comments on the changed lines and have some tests.

Maybe we can set theUser-Agent togit-lfs/3.6.0 (GitHub; darwin arm64; go 1.23.3) so it looks more like real.

Copy link

Member

lunny commentedDec 13, 2024

I can confirm this PR fixed the bug. It's better to have some comments on the changed lines and have some tests.
Maybe we can set theUser-Agent togit-lfs/3.6.0 (GitHub; darwin arm64; go 1.23.3) so it looks more like real.

Why Github? Since the git lfs client inside Gitea is a new implementation, the version is also not right. Maybe we can use Gitea's version instead. So likelygit-lfs/1.22.6 (Gitea; darwin arm64; go 1.23.3).

Copy link

MemberAuthor

hiifong commentedDec 13, 2024

I can confirm this PR fixed the bug. It's better to have some comments on the changed lines and have some tests.
Maybe we can set theUser-Agent togit-lfs/3.6.0 (GitHub; darwin arm64; go 1.23.3) so it looks more like real.
Why Github? Since the git lfs client inside Gitea is a new implementation, the version is also not right. Maybe we can use Gitea's version instead. So likelygit-lfs/1.22.6 (Gitea; darwin arm64; go 1.23.3).

Agree