Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add file tree to file view page#32721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@kerwin612
Copy link
Member

@kerwin612kerwin612 commentedDec 5, 2024•
edited by lunny
Loading

Resolve#29328

This pull request introduces a file tree on the left side when reviewing files of a repository.

32721

delvh, anbraten, a1012112796, mitsimi, lunny, ankurk91, huapox, GiaNTizmO, appleboy, Felitendo, and MultiMote reacted with thumbs up emojiyp05327, hiifong, lunny, KN4CK3R, and Glandos reacted with hooray emojilunny reacted with heart emojilunny and quentinguidee reacted with rocket emojihuapox reacted with eyes emoji
@GiteaBotGiteaBot added the lgtm/need 2This PR needs two approvals by maintainers to be considered for merging. labelDec 5, 2024
@kerwin612kerwin612 marked this pull request as draftDecember 5, 2024 02:38
@github-actionsgithub-actionsbot added modifies/templatesThis PR modifies the template files modifies/frontend labelsDec 5, 2024
@yp05327yp05327 added this to the1.24.0 milestoneDec 5, 2024
@kerwin612kerwin612 marked this pull request as ready for reviewDecember 5, 2024 06:34
@github-actionsgithub-actionsbot added the modifies/goPull requests that update Go code labelDec 5, 2024
@lunny
Copy link
Member

lunny commentedDec 5, 2024•
edited
Loading

1 Move the three buttons on top of the left tree when expanding and move to the right once folding.
图片

2 The expanding state should be stored to users' configuration or as a session value once changed.
3 It should be sorted so that folders should always be on top of files on the left tree.
图片

@wxiaoguangwxiaoguang marked this pull request as draftDecember 7, 2024 03:21
@kerwin612kerwin612force-pushed theadd-file-tree-to-file-view-page branch from7229b60 to59e46d4CompareDecember 13, 2024 06:30
@kerwin612kerwin612force-pushed theadd-file-tree-to-file-view-page branch frome45940d toc4e7f0cCompareDecember 13, 2024 12:20
@GiteaBotGiteaBot added lgtm/need 1This PR needs approval from one additional maintainer to be merged. and removed lgtm/blockedA maintainer has reservations with the PR and thus it cannot be merged labelsMar 15, 2025
@wxiaoguang
Copy link
Contributor

Almost done from my side. Still not ideal, could leave the improvements to the future.

@kerwin612@lunny please confirm whether the changes look good

@wxiaoguangwxiaoguangforce-pushed theadd-file-tree-to-file-view-page branch from405fa10 tob66330bCompareMarch 15, 2025 07:04
@wxiaoguangwxiaoguangforce-pushed theadd-file-tree-to-file-view-page branch fromb66330b to19e23daCompareMarch 15, 2025 07:09
@GiteaBotGiteaBot added lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1This PR needs approval from one additional maintainer to be merged. labelsMar 15, 2025
@wxiaoguangwxiaoguang marked this pull request as ready for reviewMarch 15, 2025 07:11
@wxiaoguangwxiaoguang merged commit92f997c intogo-gitea:mainMar 15, 2025
26 checks passed
@wxiaoguang
Copy link
Contributor

Merged, do more improvements in the future.

@wxiaoguangwxiaoguang deleted the add-file-tree-to-file-view-page branchMarch 15, 2025 08:27
data-tooltip-content="{{ctx.Locale.Tr"repo.diff.hide_file_tree"}}">
{{svg"octicon-sidebar-expand"}}
</button>
<b>Files</b>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should translate this, fwiw.

@lunnylunny mentioned this pull requestMar 15, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull requestMar 17, 2025
* giteaofficial/main: (23 commits)  [skip ci] Updated translations via Crowdin  Update tool dependencies (go-gitea#33907)  Move hooks function to gitrepo and reduce expose repopath (go-gitea#33890)  Replace text-align classes with tailwind (go-gitea#33905)  Simplify secure context check (go-gitea#33906)  Update JS and PY deps, misc tweaks (go-gitea#33903)  Refactor functions to reduce repopath expose (go-gitea#33892)  Move git references checking to gitrepo packages to reduce expose of repository path (go-gitea#33891)  [skip ci] Updated translations via Crowdin  Add missing translation (go-gitea#33900)  Give organisation members access to organisation feeds (go-gitea#33508)  Add lock for a repository pull mirror (go-gitea#33876)  Fix cannot delete runners via the modal dialog (go-gitea#33895)  Add file tree to file view page (go-gitea#32721)  [skip ci] Updated translations via Crowdin  Feature: Ephemeral action runners (go-gitea#33570)  Add abstraction layer to delete repository from disk (go-gitea#33879)  Make SearchMode have default value and add comments (go-gitea#33863)  Fix maven panic when no package exists (go-gitea#33888)  Add old svg class name to git entry icon (go-gitea#33884)  ...# Conflicts:#templates/repo/wiki/revision.tmpl
@go-giteago-gitea deleted a comment fromhuapoxApr 9, 2025
@eric-j-ason
Copy link
Contributor

Should it not be possible to see it also on the main page of a repo?

@silverwind
Copy link
Member

The main page is already a folder view, and that's not how it works on GitHub, so I think no.

@go-giteago-gitea locked asresolvedand limited conversation to collaboratorsJun 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@silverwindsilverwindsilverwind left review comments

@lunnylunnylunny approved these changes

@wxiaoguangwxiaoguangwxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/doneThis PR has enough approvals to get merged. There are no important open reservations anymore.modifies/frontendmodifies/goPull requests that update Go codemodifies/templatesThis PR modifies the template filestype/changelogAdds the changelog for a new Gitea versiontype/featureCompletely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

[Feature Request] File Tree For Preview Mode

7 participants

@kerwin612@lunny@yp05327@wxiaoguang@eric-j-ason@silverwind@GiteaBot
[8]ページ先頭
©2009-2025 Movatter.jp