Please have a look at this and let me know if I did some structural things wrong, as I have zero experience with Go but came across the mentioned issues myself and tried to add the optional setting to fix them.

Could you have some tests?

Could you have some tests?

I'll have a look. But I'm not quite sure as to what the focus of these test should be, as outgoing emails aren't tested anywhere. I could simply test my own additions whithout any actual email integration (the parsing of the html and replacement of the img tags and whether other image tags stay the same). Sounds fine?

Could you have some tests?

I'll have a look. But I'm not quite sure as to what the focus of these test should be, as outgoing emails aren't tested anywhere. I could simply test my own additions whithout any actual email integration (the parsing of the html and replacement of the img tags and whether other image tags stay the same). Sounds fine?

Yes. Thank you.

I added test to this. however I can't integrate them into services/mailer/mail_test.go because I need the testing environment which would form an import cycle. Now I exported the MailCommentContext and my newly added functions. Let me know if there is a way around this, but I see this as nothing big as these functions are not context specific. I'll squash the commits after you reviewed it

Still fails because I didn't account for using minio. Will rework...

Will do some refactoring first before continuing this. Thank you for your patience.

Made some changes:

• Only keep one "EMBED_ATTACHMENT_IMAGES" config option, the size limit is hard-coded to 9MB. I think this limit is good enough to most users, and avoid bloating Gitea's config system too much.
  • If there are special requests, there is always a chance to add the "limit" config option back.
• Instead of "guessing" the "attachments" path, use a strict parser to parse Gitea's route path