Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork6.3k
Add auto-expanding running actions step#30058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add auto-expanding running actions step#30058
Uh oh!
There was an error while loading.Please reload this page.
Conversation
KN4CK3R commentedMar 25, 2024
I think that's a feature some people will like but others will not like it. So a toggle/option may be needed. |
silverwind commentedMar 25, 2024
Seems alright to me, even with no opt-out as GitHub does this too. |
bytedream commentedMar 25, 2024
I got inspired from GitHub for this. Besides being nice in general (imo), this PR is a useful addition to action auto-scrolling (#30057) . With both merged, when the user opens a running action, it directly jumps to the latest output log, without the need of manually opening the currently running job step and scrolling down. |
silverwind commentedMar 28, 2024
I think this is a valuable feature to have, but I need to get around to testing it first as I don't have a persistent action runner in my dev environment yet, so it's always a bit of a pain to test actions. |
lunny commentedApr 11, 2024
You can run a runner with docker in the same dev machine. |
wxiaoguang commentedDec 21, 2024
I could agree with it.
The question is why users need to see the "latest output log" for a "running step". Think about 2 cases:
So IMO case1 and case2 are similar: if a user is interested in some steps, they could expand the logs, otherwise no need to expand automatically. |
wxiaoguang commentedDec 21, 2024
Or maybe we could use local storage to introduce 2 lightweight config options: "always auto expand", "always auto scroll", then it could satisfy all users. |
wxiaoguang commentedDec 22, 2024
Now it should satisfy all users.@bytedream does it look good to you? |
bytedream commentedDec 22, 2024
@wxiaoguang looks good 👍 ty |
6279646 intogo-gitea:mainUh oh!
There was an error while loading.Please reload this page.
* giteaofficial/main: (62 commits) Fix repo avatar conflict (go-gitea#32958) [skip ci] Updated licenses and gitignores fix trailing comma not matched in the case of alphanumeric issue (go-gitea#32945) Add auto-expanding running actions step (go-gitea#30058)Fixgo-gitea#32954 (go-gitea#32955) Use Alpine 3.21 for the docker images (go-gitea#32924) Refactor template & test related code (go-gitea#32938) Use primary as button color (go-gitea#32949) [skip ci] Updated translations via Crowdin Add action auto-scroll (go-gitea#30057) Fix locale (go-gitea#32937) Enable Typescript `strictFunctionTypes` (go-gitea#32911) Fix areYouSure confirm (go-gitea#32941) Update i18n.go - Language Picker (go-gitea#32933) Move some errors to their own sub packages (go-gitea#32880) Improve navbar: add "admin" tip, add "active" style (go-gitea#32927) Refactor db package and remove unnecessary `DumpTables` (go-gitea#32930) show warning on navigation if currently editing comment or title (go-gitea#32920) Refactor pprof labels and process desc (go-gitea#32909) [skip ci] Updated translations via Crowdin ...

Auto-expands the currently running action step.