Commit62a77b7

authored

plumbing: Fix invalid reference name error while cloning branches containing /- (#1257)

* plumbing: Fix invalid reference name error while cloning branches containing /-* Tests

1 parent65f5e1a commit62a77b7Copy full SHA for 62a77b7

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -188,7 +188,7 @@ func (r ReferenceName) Validate() error {`
`188`	`188`
`189`	`189`	`isBranch:=r.IsBranch()`
`190`	`190`	`isTag:=r.IsTag()`
`191`		`-for_,part:=rangeparts {`
	`191`	`+fori,part:=rangeparts {`
`192`	`192`	`// rule 6`
`193`	`193`	`iflen(part)==0 {`
`194`	`194`	`returnErrInvalidReferenceName`
`@@ -205,7 +205,7 @@ func (r ReferenceName) Validate() error {`
`205`	`205`	`returnErrInvalidReferenceName`
`206`	`206`	`}`
`207`	`207`
`208`		`-if (isBranch\|\|isTag)&&strings.HasPrefix(part,"-") {// branches & tags can't start with -`
	`208`	`+if (isBranch\|\|isTag)&&strings.HasPrefix(part,"-")&& (i==2){// branches & tags can't start with -`
`209`	`209`	`returnErrInvalidReferenceName`
`210`	`210`	`}`
`211`	`211`	`}`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,8 @@ func (s ReferenceSuite) TestValidReferenceNames(c C) {`
`115`	`115`	`"refs/pulls/1/abc.123",`
`116`	`116`	`"refs/pulls",`
`117`	`117`	`"refs/-",// should this be allowed?`
	`118`	`+"refs/ab/-testing",`
	`119`	`+"refs/123-testing",`
`118`	`120`	`}`
`119`	`121`	`for_,v:=rangevalid {`
`120`	`122`	`c.Assert(v.Validate(),IsNil)`

Comments

(0)