Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

fix(avl/pager): put back missing tests#3979

Merged
moul merged 28 commits intognolang:masterfromUrsulovic:pager-improvement
Mar 20, 2025

Conversation

Ursulovic
Copy link
Contributor

Restoring Missing Tests

This PR restores tests that were unintentionally removed while working onthis PR. It does not introduce any new features; it simply reinstates the missing tests ingno.land/p/demo/avl/pager/pager_test.gno.

Ivan Ursulovicand others added27 commitsFebruary 14, 2025 14:39
@github-actionsgithub-actionsbot added the 🧾 package/realmTag used for new Realms or Packages. labelMar 19, 2025
@Gno2D2Gno2D2 requested a review froma teamMarch 19, 2025 22:39
@Gno2D2
Copy link
Collaborator

Gno2D2 commentedMar 19, 2025
edited
Loading

🛠 PR Checks Summary

AllAutomated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
  • The pull request description provides enough details
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or includeBREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met└── 🟢 And    ├── 🟢 The base branch matches this pattern: ^master$    └── 🟢 The pull request was created from a fork (head branch repo: Ursulovic/gno)

Then

🟢 Requirement satisfied└── 🟢 Maintainer can modify this pull request
Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met└── 🟢 And    ├── 🟢 The base branch matches this pattern: ^master$    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied└── 🟢 If    ├── 🟢 Condition    │   └── 🟢 Or    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request    │       └── 🔴 This pull request is a draft    └── 🟢 Then        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met└── 🟢 And    ├── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)    └── 🟢 Not (🔴 Pull request author is user: dependabot[bot])

Can be checked by

  • team core-contributors

@UrsulovicUrsulovic changed the titlePager improvement - returning of missing testsfix(Pager improvement) -Returning of missing testsMar 19, 2025
@UrsulovicUrsulovic changed the titlefix(Pager improvement) -Returning of missing testsfix(Pager improvement) Returning of missing testsMar 19, 2025
@UrsulovicUrsulovic changed the titlefix(Pager improvement) Returning of missing testsfix: Pager improvement - Returning of missing testsMar 19, 2025
@UrsulovicUrsulovic marked this pull request as ready for reviewMarch 19, 2025 23:11
@Gno2D2Gno2D2 added the review/triage-pendingPRs opened by external contributors that are waiting for the 1st review labelMar 19, 2025
Copy link
Contributor

@leohhhnleohhhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Checked with the diff from before#3760 was merged and this PR. LGTM

@leohhhnleohhhn changed the titlefix: Pager improvement - Returning of missing testsfix(avl/pager): put back missing testsMar 20, 2025
@Gno2D2Gno2D2 removed the review/triage-pendingPRs opened by external contributors that are waiting for the 1st review labelMar 20, 2025
@moulmoul merged commitcc6a3c3 intognolang:masterMar 20, 2025
78 of 82 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@moulmoulmoul approved these changes

@leohhhnleohhhnleohhhn approved these changes

Assignees

@UrsulovicUrsulovic

Labels
🧾 package/realmTag used for new Realms or Packages.
Projects
Status: Done
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Ursulovic@Gno2D2@moul@leohhhn

[8]ページ先頭

©2009-2025 Movatter.jp