NotificationsYou must be signed in to change notification settings
Fork397
Star939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

feat(examples): add URL query params to`mux` package request#3950

Merged

leohhhn merged 3 commits intomasterfromdev/jeronimoalbi/package-mux-query-params

Mar 19, 2025

Merged

feat(examples): add URL query params to`mux` package request#3950

leohhhn merged 3 commits intomasterfromdev/jeronimoalbi/package-mux-query-params

Mar 19, 2025

Conversation

Copy link

Member

jeronimoalbi commentedMar 16, 2025•
edited
Loading

PR adds aQuery property with the parsed URL query arguments to themux.Request to be able to get query arguments like:

req.Query.Get("argName")

feat: add URL query params tomux package request

f63388b

jeronimoalbi requested review frommoul,ilgooz,salmad3 andleohhhn

March 16, 2025 14:58

jeronimoalbi self-assigned this

Mar 16, 2025

github-actionsbot added the 🧾 package/realmTag used for new Realms or Packages. label

Mar 16, 2025

Gno2D2 added the review/triage-pendingPRs opened by external contributors that are waiting for the 1st review label

Mar 16, 2025

Copy link

Collaborator

Gno2D2 commentedMar 16, 2025•
edited
Loading

🛠 PR Checks Summary

AllAutomated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or includeBREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met└── 🟢 And    ├── 🟢 The base branch matches this pattern: ^master$    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied└── 🟢 If    ├── 🟢 Condition    │   └── 🟢 Or    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request    │       └── 🔴 This pull request is a draft    └── 🟢 Then        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met└── 🟢 On every pull request
Can be checked by
Any user with comment edit permission