Could you please try to use Tailwind and its config theme instead of using a new classes, new colors etc?

fffb7f4
It's good if i use<a href="/%s$source">&#34;%s&#34;</a> the same color as the original import ?

This is a hack

We have an extensible markdown engine, we should implement this as an extension there, unless you can show it's impossible

Using Chroma would be correct but also more robust, maintainable, and less dependent on final HTML structure.

@thehowl This feature is not related togoldmark, but rather tochroma, which is responsible for syntax highlighting.

I gave a quick look atchroma to explore integration possibilities. Unfortunately, extending it is bit challenging, but not impossible. It would require creating a new renderer and a new lexer forgno, supporting import as a specific token, and integrating it into the rendering system.

This PR is indeed a hacky solution; even if it can be negligible most of the time, usingre.ReplaceAllString to process the whole file can be a heavy task based on the file size andI wonder if it could not even be a potential DDoS vector if people create some on-purpose files containing ton of"gno.land/.*" string reference (probably still negligible). Also, it relies on Chroma syntax, which can change over time. But the main issue is that we will likely and quickly encounter other changes like this one, e.g., linking the source function to the documentation page, adding hover variable inspection, etc. We cannot apply this hack every time we want to integrate source extensions.

I'm unsure whether to wait for a proper Chroma extension or to merge this as a temporary solution. Another less risky option could be to implement this hack on the JS side temporarily, as it would be better for the client to handle this "heavy" task (cc@alexiscolin). However, since there is nothing urgent, I'm hesitant to rush into a hacky and temporary solution.

Thanks for your feedback@thehowl@gfanton@alexiscolin

I'm currently exploring possible ways to solving this issue. the best solution in my opinion is to extendchroma forgno, and then there will be more possibilities to manipulate source code, what do you think about that ?

I can put this PR in draft and working on it if you want

I'm not worried on the regex/performance side; Go's regex engine is very good and runs inO(n). I'm just worried that this is too dependent on the syntax coming out of goldmark and is not robust.

Goldmark highlighting is added with an extension that does the following:

m.Renderer().AddOptions(renderer.WithNodeRenderers(util.Prioritized(NewHTMLRenderer(e.options...), 200),))

Can we not also add an extension on the renderer, that runs after the HTMLRenderer (which adds the syntax highlighting)?

goldmark useschroma under the hood to generate the highlight. So you cannot just extendgoldmark. You necessarily have to extendchroma first.

Please, update chroma so that everything we do for "source code viewer" may also work for when we embed gno code in the render function, i.e.,

lorem ipsum```gnoimport "gno.land/p/demo/avl"// ...```foo bar

my request isn't about this PR especially but about the current way gnoweb use chroma in two different manners. i think this can be tackled in a dedicated PR (cc@alexiscolin@gfanton)

Fine, we can go with the regex and then look to improve this on chroma eventually. We have tests so we should know if it breaks.

Let's address moul's feedback then we're good to go I'd say?