Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

feat(p/uint256): Add overflow check and fullmath calculation functions#3684

Open
notJoon wants to merge2 commits intognolang:master
base:master
Choose a base branch
Loading
fromnotJoon:uint256-more-functions

Conversation

notJoon
Copy link
Member

Description

  • Added theisOverflow function to checks if a number exceeds the 256-bit uint range limit by verifying if the 256th bit is set.
  • FullMath Calculation Functions
    • added full-precision math operations, includingMulDiv,MulDivRoundingUp, andDivRoundingUp
    • These functions implement a 512×256-bit division algorithm
  • Updated docs forbits_table
  • Changed to useuassert package in test codes

@notJoonnotJoon added the review/triage-pendingPRs opened by external contributors that are waiting for the 1st review labelFeb 4, 2025
@github-actionsgithub-actionsbot added the 🧾 package/realmTag used for new Realms or Packages. labelFeb 4, 2025
@Gno2D2Gno2D2 requested a review froma teamFebruary 4, 2025 11:45
@Gno2D2
Copy link
Collaborator

Gno2D2 commentedFeb 4, 2025
edited
Loading

🛠 PR Checks Summary

🔴 Pending initial approval by a review team member, or review from tech-staff

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or includeBREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met└── 🟢 And    ├── 🟢 The base branch matches this pattern: ^master$    └── 🟢 The pull request was created from a fork (head branch repo: notJoon/gno-core)

Then

🟢 Requirement satisfied└── 🟢 Maintainer can modify this pull request
Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met└── 🟢 And    ├── 🟢 The base branch matches this pattern: ^master$    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🔴 Requirement not satisfied└── 🔴 If    ├── 🔴 Condition    │   └── 🔴 Or    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")    │       ├── 🔴 At least 1 user(s) of the team tech-staff reviewed pull request    │       └── 🔴 This pull request is a draft    └── 🔴 Else        └── 🔴 And            ├── 🟢 This label is applied to pull request: review/triage-pending            └── 🔴 On no pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecovCodecov
Copy link

codecovbot commentedFeb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report?Let us know!

@thehowl
Copy link
Member

Can you provide some context, especially on thefullmath functions?

@jefft0
Copy link
Contributor

Can you provide some context, especially on thefullmath functions?

@notJoon , do you have a reply to this question?

@Kouteki
Copy link
Contributor

Message from@notJoon

This is a PR updated to synchronize with the version being used in gnoswap. The purpose was to remove the package being used on our side once this is merged, but I forgot to add an description.

mvertes added a commit that referenced this pull requestMar 4, 2025
Apply Bigint.Not for untyped big ints.Fixes#3684.
@jefft0
Copy link
Contributor

@notJoon , please merge master and fix the failed CI check.

notJoon reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aeddiaeddiAwaiting requested review from aeddi

@mvertesmvertesAwaiting requested review from mvertes

At least 1 approving review is required to merge this pull request.

Assignees

@notJoonnotJoon

Labels
🧾 package/realmTag used for new Realms or Packages.review/triage-pendingPRs opened by external contributors that are waiting for the 1st review
Projects
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@notJoon@Gno2D2@thehowl@jefft0@Kouteki

[8]ページ先頭

©2009-2025 Movatter.jp