- Notifications
You must be signed in to change notification settings - Fork397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(boards2): implement next boards version#2901
Open
ilgooz wants to merge117 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report?Let us know! |
be049e7 tobaf9821CompareBoards v2 package and realm API experimentation<details><summary>Contributors' checklist...</summary>- [ ] Added new tests, or not needed, or not feasible- [ ] Provided an example (e.g. screenshot) to aid review or the PR isself-explanatory- [ ] Updated the official documentation or not needed- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` messagewas included in the description- [ ] Added references to related issues and PRs- [ ] Provided any useful hints for running manual tests- [ ] Added new benchmarks to [generatedgraphs](https://gnoland.github.io/benchmarks), if any. More info[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).</details>---------Co-authored-by: İlker G. Öztürk <ilker@ilgooz.com>Co-authored-by: Denys Sedchenko <denis0051@gmail.com>
7 tasks
Co-authored-by: Manfred Touron <94029+moul@users.noreply.github.com>Co-authored-by: Jae Kwon <53785+jaekwon@users.noreply.github.com>Co-authored-by: Jeff Thompson <jeff@thefirst.org>Co-authored-by: Hariom Verma <hariom.verma@tendermint.com>Co-authored-by: Morgan <morgan@morganbaz.com>Co-authored-by: Albert Le Batteux <contact@albttx.tech>Co-authored-by: Guilhem Fanton <8671905+gfanton@users.noreply.github.com>Co-authored-by: Blake <104744707+r3v4s@users.noreply.github.com>Co-authored-by: Jeff Thompson <jeff@berty.tech>Co-authored-by: Leon Hudak <33522493+leohhhn@users.noreply.github.com>Co-authored-by: Poroburu <poroburu@gmail.com>Co-authored-by: deelawn <dboltz03@gmail.com>Co-authored-by: grepsuzette <350354+grepsuzette@users.noreply.github.com>Co-authored-by: jon roethke <waymobetta@users.noreply.github.com>
Refactors the code copied from `gno.land/r/demo/boards` to simplify itand to have it ready before introducing the new features.
Use correct package name for boards2 realm.
Related to#3139Permissioner interface is defined based on Jae's idea to handle permissioned tasks.---------Co-authored-by: Jae Kwon <53785+jaekwon@users.noreply.github.com>
🛠 PR Checks SummaryAllAutomated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
This is an initial implementation to unblock features that depend onboard permissions.
Add flagging support for boards2 realm.Closes#3146
PR simplifies the freeze implementation to follow realm coding patterns.To do so argument type was removed and arguments were changed to befunction arguments instead of properties of a type.Two public function files were introduced to group public functions byconcern to have a smaller `public.gno` file.
Once#3882 is merged we should remove the For context, the |
PR adds support to `boards2` realm so it can be locked.Realm can be locked leaving the possibility to manage realm members(council DAO) open or otherwise can be fully locked disallowing anymember changes.Support for setting a global notice message is also part of this PR.Notice can be used as a standalone feature or in conjunction with thelocking functionality to inform users of the location of the new realmversion.Part of#3494Also see[comment](#3494 (comment))
This package is now part of PR#3882 and has been moved to`gno.land/p/gnoland/commondao`.
PR is ready for review at this point. Tests are failing because we have to integrate with |
Latest `p/gnoland/commondao` package now uses different member relatedmethods.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.