Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: only consider local type variables in error's type printing#5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ankddev wants to merge3 commits intogleam-lang:main
base:main
Choose a base branch
Loading
fromankddev:fix-3786

Conversation

@ankddev
Copy link
Contributor

This PRfixes#3786.

Copy link
Member

@GearsDatapacksGearsDatapacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hello! Could you add some tests to this please? I would like tests for:

  • Ignoring type variables in other functions
  • Correctly using type variables defined in the current function
  • Correctly generating a new name to avoid clashing with type variables in the current function

ankddev reacted with thumbs up emoji
@ankddev
Copy link
ContributorAuthor

ankddev commentedOct 7, 2025
edited
Loading

@GearsDatapacks Okay, can you please give me some guidance about where they should be located? :)

@GearsDatapacks
Copy link
Member

They should go in thetype_::tests::errors module

ankddev reacted with thumbs up emoji

@ankddevankddev marked this pull request as draftOctober 7, 2025 15:36
@ankddev
Copy link
ContributorAuthor

There are some problems with this, I'll address them later, so drafting PR for now!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@GearsDatapacksGearsDatapacksGearsDatapacks left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error's type printing: Consider only annotated type variables for the current definition rather than the whole module

2 participants

@ankddev@GearsDatapacks

[8]ページ先頭

©2009-2025 Movatter.jp