Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP: Retries#232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
gjoseph92 wants to merge6 commits intomain
base:main
Choose a base branch
Loading
fromretries
Draft

WIP: Retries#232

gjoseph92 wants to merge6 commits intomainfromretries

Conversation

gjoseph92
Copy link
Owner

Support retrying errors matching a given pattern.

This also moves error handling logic (both retires and nodata) up to theto_dask level, and out of Readers.

Closes#18.

Still need to do sleep/backoff, etc. Hoping to remove NodataReader too.
When an `open` fails and we'd return nodata instead, we don't cache that anymore. So if the asset doesn't exist, we'll try to open it for every chunk. Unclear how much of a performance impact this will have. It's probably not ideal, because combining it with retries could be nice: retry errors first, then give up and use nodata if they persist?
got lost in#221, which was a reasonable change, but turns out there was still a test importing it
TODO:- sleep & backoff- figure out how to handle sleep in tests
@charalamm
Copy link

charalamm commentedDec 8, 2023
edited
Loading

Hi@gjoseph92 thanks for this feature. I had a look an although I have not tested the code it looks good. The way of using this feature seems versatile so imho, nice, I would defiantly use this feature!

I see that you have not included theCPL_VSIL_CURL_NON_CACHED gdal parameter. Does the retry work without it or the users need to add ingdal_env?

Also, I would think that the possibility to add a delay between retries would be also useful.

@charalamm
Copy link

charalamm commentedJan 19, 2024
edited
Loading

Hello@gjoseph92 . Do you think you will merge this anytime soon?
Let me know if I can help somehow

gjoseph92 added a commit that referenced this pull requestAug 10, 2024
Opted not to refactor `NodataReader` as described in comments because#232 removes it all together, and I don't need even more merge conflicts someday.Fixes#243
gjoseph92 added a commit that referenced this pull requestAug 10, 2024
Opted not to refactor `NodataReader` as described in comments because#232 removes it all together, and I don't need even more merge conflicts someday.Fixes#243
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling intermittent data retrieval errors (retries)
2 participants
@gjoseph92@charalamm

[8]ページ先頭

©2009-2025 Movatter.jp