NotificationsYou must be signed in to change notification settings
Fork27
Star71

Replace use of mktemp#56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Byron merged 1 commit intogitpython-developers:masterfromEliahKagan:no-mktemp

Dec 13, 2023

Merged

Replace use of mktemp#56

Byron merged 1 commit intogitpython-developers:masterfromEliahKagan:no-mktemp

Dec 13, 2023

Conversation

Copy link

Member

EliahKagan commentedDec 13, 2023•
edited
Loading

Fixes#41

This usesNamedTemporaryFile withdelete=False to replace the one use of the deprecatedmktemp function in smmap (reported in#41).

This avoids the race condition inherent tomktemp, as the file is named and created together in a way that is effectively atomic.

BecauseNamedTemporaryFile is not being used to automatically delete the file, it use and cleanup are unaffected by the change.

(This PR is conceptually related togitpython-developers/GitPython#1770.)

Replace use of mktemp

a315725

This uses NamedTemporaryFile with delete=False to replace the oneuse of the deprecated mktemp function in smmap (reported ingitpython-developers#41).This avoids the race condition inherent to mktemp, as the file isnamed and created together in a way that is effectively atomic.Because NamedTemporaryFile is not being used to automaticallydelete the file, it use and cleanup are unaffected by the change.