- Notifications
You must be signed in to change notification settings - Fork66
No longer treat 3.12 as experimental on CI#97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This makes it easier to test changes to CI without/before a PR.+ Fix a small YAML indentation style inconsistency.
Since Python 3.12.0 stable has been released, as well as now beingavailable via setup-python, per:https://github.com/actions/python-versions/blob/main/versions-manifest.jsonThe main practical effect of this is that continue-on-error is nolonger set to true for 3.12, so 3.12 is no longer special-cased torefrain from cancelling other test jobs when its test job fails.Another effect is that 3.12 can longer be selected as a prerelease.
Thanks a lot, also for making the CI triggers more uniform in respect to GitPython and practical :). |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Python 3.12.0 stable has been released, as well as now beingavailable via setup-python, and these tests have been passing with the release candidate. So this changes the CI test workflow to no longer treat it as experimental. This has two effects:
continue-on-erroris no longer set to true for 3.12, so 3.12 is no longer special-cased to refrain from cancelling other test jobs when its test job fails. This is the more significant effect.fail-fasttofalse, so one job failing never automatically cancels another job).With respect to the latter, as well as in a broad conceptual sense, this PR corresponds togitpython-developers/GitPython#1689.
In addition to those changes, I have also changed this to be triggered the same ways as in GitPython, so that CI test jobs run on all branches. This makes it easier to test changes to CI without, or before, opening a PR. (It also reduces the temptation to use one's fork's default branch for feature development.) However, if you prefer this not be done, I'd be pleased to remove it.
The exactly corresponding PR to this one, in smmap, isgitpython-developers/smmap#54.