Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Don't cancel other jobs from the 3.12 job failing#93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:masterfromEliahKagan:ci-continue
Sep 11, 2023

Conversation

EliahKagan
Copy link
Member

@EliahKaganEliahKagan commentedSep 11, 2023
edited
Loading

Because 3.12 is still a release candidate and if tests fail for it then one would always want to know if/how other versions also fail.

Note that a failure of the 3.12 job will still be treated as a failed check and will still cause the workflow to be considered to have failed, which we probably want. Settingcontinue-on-error for the job just overrides the default matrixfail-fast behavior, so the 3.12 job won't cause other jobs from the matrix to be cancelled if it fails. (Other jobs will still cause cancellation.)

I used a technique based onthe one in the GitHub Actions documentation, but modified so all versions can be listed in one place and so the automatically generated job names remain short, as they were before.

This also allowsactions/setup-python to install a prerelease for 3.12only, and no longer for other releases. (This is less important, because only under very strange circumstances would only an old prerelease of a stable release be available to the CI runner. But treating 3.12 specially, as above, allows this to be done too, with no increase in complexity.)

This may or may not be considered worthwhile, given that it should be undone sometime not long after the stable 3.12.0 comes out. However, I think theallow-preleases override totrue should be undone at that time, so it seems to me that the burden is much the same either way (and the stakes very low, either way, if it is left in place too long).

Because 3.12 is still a release candidate and if tests fail for itthen one would always want to know if/how other versions also fail.This also allows actions/setup-python to install a prerelease for3.12 only, not for other releases.
@EliahKaganEliahKagan marked this pull request as ready for reviewSeptember 11, 2023 08:56
Copy link
Member

@ByronByron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks a lot! I think this is similarly implemented in GitPython (soon) and it's a neat way of achieving this.

EliahKagan reacted with thumbs up emoji
@ByronByron merged commit2916865 intogitpython-developers:masterSep 11, 2023
@EliahKaganEliahKagan deleted the ci-continue branchSeptember 11, 2023 09:20
@EliahKagan
Copy link
MemberAuthor

EliahKagan commentedSep 11, 2023
edited
Loading

Thanks! Yes, I used the same pattern ingitpython-developers/GitPython#1654, though (in my mind) not entirely for the same purpose.

Here in gitdb's workflow file,fail-fast is not explicitly set, so it has its default value oftrue, and the main purpose ofexperimental here is to weaken that appropriately for 3.12 because it is a prerelease, by settingcontinue-on-error totrue for it. While I was at it, I also used it to only permitsetup-python to install a prerelease for 3.12.

In contrast, GitPython's roughly corresponding workflow file explicitly setsfail-fast tofalse, so there is no need to setcontinue-on-error, which I didn't do. Instead, I introducedexperimental there just for the purpose of limitingsetup-python to installing a prerelease for 3.12.

Byron reacted with thumbs up emoji

EliahKagan added a commit to EliahKagan/smmap that referenced this pull requestSep 17, 2023
This updates smmap's CI configuration in ways that are in line withrecent updates to gitdb's. In most cases there is no difference inthe changes, and the reason for the updates is more to avoidconfusing differences than from the value of the changesthemselves. In one case, there is a major difference (fetch-depth).-gitpython-developers/gitdb#89 (same)-gitpython-developers/gitdb#90 (same)  It's just the project, not dependencies, but otherwise the same.-gitpython-developers/gitdb#92 (opposite)  This is the major difference. We don't need more than the tip of  the branch in these tests. Keeping the default fetch-depth of 1  by not setting it explicitly avoids giving the impression that  the tests here are doing something they are not (and also serves  as a speed optimization).-gitpython-developers/gitdb#93 (same)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ByronByronByron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@EliahKagan@Byron

[8]ページ先頭

©2009-2025 Movatter.jp