- Notifications
You must be signed in to change notification settings - Fork66
Use actions/checkout feature to fetch all commits#92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Setting the "fetch-depth" to a positive value fetches that manycommits back (and the default value is 1), but setting it to 0fetches all commits, as in a (deep) normal fetch.
Thank you! I agree that setting it to zero is an indication that we need a couple of commits for tests to work. This reminds me of another glaring issue of GitPython: tests are not isolated and require a certain initial state that affects ones own work-environment. In practice, that's not an issuemost of the time, but it's an issue nonetheless. In |
This updates smmap's CI configuration in ways that are in line withrecent updates to gitdb's. In most cases there is no difference inthe changes, and the reason for the updates is more to avoidconfusing differences than from the value of the changesthemselves. In one case, there is a major difference (fetch-depth).-gitpython-developers/gitdb#89 (same)-gitpython-developers/gitdb#90 (same) It's just the project, not dependencies, but otherwise the same.-gitpython-developers/gitdb#92 (opposite) This is the major difference. We don't need more than the tip of the branch in these tests. Keeping the default fetch-depth of 1 by not setting it explicitly avoids giving the impression that the tests here are doing something they are not (and also serves as a speed optimization).-gitpython-developers/gitdb#93 (same)
It appears the intent of specifying a
fetch-depthof1000is that 1000 is greater enough than the current number of commits in the repository that it will fetch the whole branch history, now and for some time into the future.Assuming that is the case, I recommenddoing a full fetch instead, which this PR changes it to do. Setting the
fetch-depthto a positive value fetches that many commits back (and the default value is 1), but setting it to 0 fetches all commits, as in a normal deep (full) fetch.