- Notifications
You must be signed in to change notification settings - Fork66
Test installing project on CI#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This changes the CI workflow to install the project itself to getits dependency, rather than installing the dependency fromrequirements.txt. This is the more important thing to test, becauseit verifies that the project is installable and effectivelydeclares the dependencies it needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot!
I was never aware the.
syntax even existed and wonder if ultimately is just findsrequirements.txt
by convention, or if there is any other source of dependency information.
The It also can handle build backends that are not currently installed. For example, starting in Python 3.12, So Line 23 ind22ac20
That happens to be the same as in Although The other benefit of (Of course, another way to test behavior of a built sdist or wheel is to actually build one and install from it in a new environment, which tools like |
Thanks a lot for the explanation, it's much appreciated.
The |
This updates smmap's CI configuration in ways that are in line withrecent updates to gitdb's. In most cases there is no difference inthe changes, and the reason for the updates is more to avoidconfusing differences than from the value of the changesthemselves. In one case, there is a major difference (fetch-depth).-gitpython-developers/gitdb#89 (same)-gitpython-developers/gitdb#90 (same) It's just the project, not dependencies, but otherwise the same.-gitpython-developers/gitdb#92 (opposite) This is the major difference. We don't need more than the tip of the branch in these tests. Keeping the default fetch-depth of 1 by not setting it explicitly avoids giving the impression that the tests here are doing something they are not (and also serves as a speed optimization).-gitpython-developers/gitdb#93 (same)
This changes the CI workflow to install the project itself to get its dependency, rather than installing the dependency from
requirements.txt
. This is the more important thing to test, because it verifies that the project is installable and effectively declares the dependencies it needs.