- Notifications
You must be signed in to change notification settings - Fork68
Preferimport to__import__#82
Merged
Byron merged 2 commits intogitpython-developers:masterfromNov 23, 2022
Merged
Conversation
Member
Byron commentedNov 23, 2022
Thanks a lot, this change is much appreciated. It's clear that this kind of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In
__init__.pythere is a loop that invokes__import__here:gitdb/gitdb/__init__.py
Line 13 in3415e08
Since the loop only has one item this PR convert refactors it to use the standard
import.Why
Some tooling only works with modules to be imported via
importas the packages names are resolve-able without executing code, which__import__prevents.Possible Changes
If it is desired to have
smmapadded intoglobals()of__init__.py; I can remove thedel smmapline. Right now it is there because__import__, whichimportis replacing, doesnot addsmmaptoglobals()