Remove Python 2 compatibility shims#56

Merged

Byron merged 10 commits intogitpython-developers:masterfrom

Harmon758:python-2-support-removal

Feb 17, 2020

Merged

Remove Python 2 compatibility shims#56
Byron merged 10 commits intogitpython-developers:masterfrom
Harmon758:python-2-support-removal

Conversation

Copy link

Member

Harmon758 commentedFeb 16, 2020

This PR removes and replaces Python 2 compatibility shims, since Python 2 support was dropped withc880f6b in 3.0.0:

Removecompat.memoryview andcompat.PY3
Remove and replacecompat.buffer andcompat.to_bytes
Remove and replacecompat.izip withzip,compat.MAXSIZE withsys.maxsize,compat.xrange withrange
Remove and replaceencoding.string_types andencoding.text_type withstr
Remove and replaceizip inTestPack

Harmon758 added10 commits

February 16, 2020 07:06

Remove and replace compat.izip

58bce6b

Remove and replace izip in TestPack

73a9f79

Remove and replace compat.xrange

4a692fd

Remove and replace compat.buffer

3d14cc8

Remove compat.memoryview

d1c20d5

Remove and replace compat.to_bytes

59c053e

Remove and replace compat.MAXSIZE

321c3b4

Remove and replace encoding.string_types

c412680

Remove and replace encoding.text_type

77dc809

Remove compat.PY3

db9a65e

Harmon758 requested a review fromByron

February 16, 2020 14:32

Harmon758 self-assigned this

Feb 16, 2020

Byron approved these changes

Feb 17, 2020

View reviewed changes

Copy link

Member

Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Absolutely fantastic, thanks so much for your work!
I will be releasing this in a moment, and publish a new version of GitPython as well with adjusted requirements.