- Notifications
You must be signed in to change notification settings - Fork66
Add support for Python 3.13#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
b5ca26c
tod5327e9
CompareThanks for contributing, and for the hint. |
Byron approved these changesOct 9, 2024
a8c894f
intogitpython-developers:master 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
EliahKagan added a commit to EliahKagan/smmap that referenced this pull requestJan 2, 2025
This is analogous to the gitdb test workflow and `setup.py` wereupdated inhttps://github.com/gitpython-developers/gitdb/pull/114.1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available.2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap.3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases.In particular, this change, due to (1), fixes the current CIfailure for smmap observed inf31bfa3.
EliahKagan added a commit to EliahKagan/smmap that referenced this pull requestJan 2, 2025
This is analogous to the gitdb test workflow and `setup.py` wereupdated ingitpython-developers/gitdb#114.1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available.2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap.3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases.In particular, this change, due to (1), fixes the current CIfailure for smmap observed inf31bfa3.
EliahKagan added a commit to EliahKagan/smmap that referenced this pull requestJan 2, 2025
This is analogous to the gitdb test workflow and `setup.py` updatesingitpython-developers/gitdb#114.1. Testing 3.7 on 22.04 rather than 24.04 should fix the problem where it fails because Python 3.7 is not available.2. Adding Ubuntu 3.13 to CI may help reveal if there are 3.13-specific problems with smmap.3. smmap seems to be working on Python 3.13 (which is a stable Python release) and there are no specific expected problems with it, so this adds it to the list of supported releases.In particular, this change, due to (1), fixes the current CIfailure for smmap observed inf31bfa3.
EliahKagan added a commit to EliahKagan/GitPython that referenced this pull requestJan 2, 2025
This is analogous to the 3.7-related CI change in gitdb that waspart ofgitpython-developers/gitdb#114, asto part ofgitpython-developers/smmap#58.Since some tests are not yet passing on 3.13, this does not add3.13 to CI, nor to the documentation of supported versions in`setup.py`. Note that the list there is not enforced; GitPython canalready be installed on Python 3.13 and probably *mostly* works.(Seegitpython-developers#1955for details on other changes that should be made to fully supportrunning GitPython on Python 3.13.)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Python 3.13 is out, so it'd be nice if the next release of gitdb to PyPI included it in its metadata.
Though you might wanna wait forgitpython-developers/GitPython#1955?
https://pyreadiness.org/3.13/