- Notifications
You must be signed in to change notification settings - Fork66
Never add a vendored smmap directory to sys.path#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This removes the logic that appended the git submodule directoryfor smmap to sys.path under most circumstances when the versionof gitdb was not from PyPI. Now gitdb does not modify sys.path.Seegitpython-developers/GitPython#1717andgitpython-developers/GitPython#1720 forcontext. This change is roughly equivalent to the change toGitPython, though as noted the behavior being eliminated is subtlydifferent here and there.
This was referencedOct 20, 2023
Byron approved these changesOct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks a lot for tackling this 🙏!
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This removes the logic that appended the git submodule directory for
smmaptosys.pathunder most circumstances when the version ofgitdbwas not from PyPI. Nowgitdbdoes not modifysys.path.SeeGitPython#1717 andGitPython#1720 for context. This change is roughly equivalent to the change to GitPython, though as noted the behavior being eliminated is subtly different here and there.
Please note that this doesnot make any documentation changes (and the changes in#103 are not related to this).