Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork938
BF: remove ddt from requirements.txt since no ddt required at run time.#911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Otherwise, since requirements.txt is loaded into install_requires, any installationwhich manages to miss installing ddt could cause setuptools to freak out.E.g.here is a traceback from running tests of datalad ====================================================================== ERROR: datalad.metadata.tests.test_aggregation.test_update_strategy ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/datalad/metadata/metadata.py", line 511, in _get_metadata extractor_cls = extractors[mtype_key].load() File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2442, in load self.require(*args, **kwargs) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2465, in require items = working_set.resolve(reqs, env, installer, extras=self.extras) File "/home/yoh/anaconda-2018.12-3.7/envs/test-gitpython/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve raise DistributionNotFound(req, requirers) pkg_resources.DistributionNotFound: The "ddt>=1.1.1" distribution was not found and is required by GitPythonin conda environment. Original commit74a0507which added ddt there unfortunately does not state the reason so probably wasjust a slip
5 tasks
Thanks a lot! Should I cut a release? |
ContributorAuthor
yarikoptic commentedAug 22, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
If not too much trouble - it would be great! Thanks in advance! |
Done, see v3.0.2 . |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, since requirements.txt is loaded into install_requires, any installation
which manages to miss installing ddt could cause setuptools to freak out.
E.g.
here is a traceback from running tests of datalad
in conda environment. Original commit74a0507
which added ddt there unfortunately does not state the reason so probably was
just a slip