Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Method stating which commit is being played during an halted rebase#903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 4 commits intogitpython-developers:masterfromArthur-Milchior:rebase
Aug 14, 2019

Conversation

Arthur-Milchior
Copy link
Contributor

This will be useful to me at least. This way, I know that I can tell
my script to omit some specific commits. If you accept to merge it, I
may also do similar method for merges and cherry pick.

This will be useful to me at least. This way, I know that I can tellmy script to omit some specific commits. If you accept to merge it, Imay also do similar method for merges and cherry pick.
@ghost
Copy link

Thanks a lot, good idea! Great you took the extra time to make a contribution.

I would happily merge, but believe it needs some work before that could happen.

  • camel case method name should be snake case
  • Heads or commits have native types, do you think it would be more convenient to return such object instead of string?
  • please add tests for both code paths

I understand that this would mean quite some extra work, and hope you can make it work.

Besides, I am happily accepting additional quality of life methods if they meet the quality requirements.

Thanks for your consideration:)

@codecov-io
Copy link

codecov-io commentedAug 11, 2019
edited
Loading

Codecov Report

Merging#903 intomaster willdecrease coverage by1.3%.
The diff coverage is87.5%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #903      +/-   ##==========================================- Coverage   94.84%   93.54%   -1.31%==========================================  Files          59       59                Lines        9766     9792      +26     ==========================================- Hits         9263     9160     -103- Misses        503      632     +129
Impacted FilesCoverage Δ
git/repo/base.py93.04% <87.5%> (-2.37%)⬇️
git/compat.py41.21% <0%> (-23.61%)⬇️
git/test/test_util.py90.66% <0%> (-8%)⬇️
git/test/lib/asserts.py61.53% <0%> (-7.7%)⬇️
git/test/lib/helper.py85.87% <0%> (-6.26%)⬇️
git/test/test_base.py96.59% <0%> (-2.28%)⬇️
git/test/test_git.py96.66% <0%> (-2.23%)⬇️
git/objects/submodule/base.py93.08% <0%> (-1.42%)⬇️
git/test/test_repo.py96.59% <0%> (-1.4%)⬇️
... and12 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatedaa3f35...9334614. Read thecomment docs.

@Arthur-Milchior
Copy link
ContributorAuthor

What do you mean by «both code paths» ? I added a single function, and already added tests for them
I don't know what is a «quality of life method», sorry :s

@Arthur-Milchior
Copy link
ContributorAuthor

The other two requested change are already done

@Byron
Copy link
Member

Thanks for the changes. The tests would have to be added intest_repo.py, however, I can't see any change to a file related to tests.Both code paths refers to both the success case, and the one where there is no active rebase.

Screenshot 2019-08-12 at 11 01 11

My remark about 'quality of life methods' refers to your comment about adding more methods like this, which I assume are to help you work with GitPython more easily, thus improving your 'quality of life', metaphorically speaking :D.

@Arthur-Milchior
Copy link
ContributorAuthor

I added the test in a new file, and forgot to add the file to git. My bad 🈂️
Now the test is in test_repo, as you asked for.

@ByronByron added this to thev3.0.1 - Bugfixes milestoneAug 14, 2019
@Byron
Copy link
Member

Thanks a lot for your contribution! That does the trick!

@ByronByron merged commitf6fdb67 intogitpython-developers:masterAug 14, 2019
Byron pushed a commit that referenced this pull requestAug 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@Arthur-Milchior@codecov-io@Byron

[8]ページ先頭

©2009-2025 Movatter.jp