Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork966
Fix Git.transform_kwarg#899
Merged
Byron merged 1 commit intogitpython-developers:masterfromJul 29, 2019
FrNecas:frnecas-kwargs
Merged
Fix Git.transform_kwarg#899Byron merged 1 commit intogitpython-developers:masterfromFrNecas:frnecas-kwargs
Byron merged 1 commit intogitpython-developers:masterfrom
FrNecas:frnecas-kwargs
Conversation
Kwargs were not transformed correctly if a value was set to 0 due towrong if condition.Signed-off-by: František Nečas <fifinecas@seznam.cz>
Member
Byron commentedJul 29, 2019
Thanks a lot! Fantastic test and fix! I hope putting it into v3.0.0 which drops python 2 as well is working for you. |
ContributorAuthor
FrNecas commentedJul 29, 2019
Thanks for merging. We will use my branch as a dependency until v3.0.0 is released on PyPI to have it working correctly for now and then we will switch back to the PyPI release. |
kangp3 commentedAug 13, 2019
Would it be possible to backport this fix to |
Member
Byron commentedAug 14, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@kangp3 Thus far, maintaining two versions wasn't planned, but I will see if I can get a one-off release done. Published in release v2.1.14 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on our project I found that
old_repo.git.rev_list('HEAD', max_parents=0)started to work differently after the new release of GitPython and our tests started to fail. After some debugging I found the problem. Kwargs were not transformed correctly if a value was set to 0 due to wrong if condition:The commit also contains a test for the edge case.