Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix Git.transform_kwarg#899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Byron merged 1 commit intogitpython-developers:masterfromFrNecas:frnecas-kwargs
Jul 29, 2019
Merged

Fix Git.transform_kwarg#899

Byron merged 1 commit intogitpython-developers:masterfromFrNecas:frnecas-kwargs
Jul 29, 2019

Conversation

FrNecas
Copy link
Contributor

While working on our project I found thatold_repo.git.rev_list('HEAD', max_parents=0) started to work differently after the new release of GitPython and our tests started to fail. After some debugging I found the problem. Kwargs were not transformed correctly if a value was set to 0 due to wrong if condition:

>>> 0 not in (False, None)False>>> 0 is not False and 0 is not NoneTrue

The commit also contains a test for the edge case.

Kwargs were not transformed correctly if a value was set to 0 due towrong if condition.Signed-off-by: František Nečas <fifinecas@seznam.cz>
@ByronByron added this to thev3.0.0 - Remove Python 2 milestoneJul 29, 2019
@ByronByron merged commitdaa3f35 intogitpython-developers:masterJul 29, 2019
@Byron
Copy link
Member

Thanks a lot! Fantastic test and fix! I hope putting it into v3.0.0 which drops python 2 as well is working for you.

@FrNecas
Copy link
ContributorAuthor

Thanks for merging. We will use my branch as a dependency until v3.0.0 is released on PyPI to have it working correctly for now and then we will switch back to the PyPI release.

@kangp3
Copy link

Would it be possible to backport this fix tov2.X as well? We are relying on this package and unfortunately haven't dropped Python 2 support just yet.

@Byron
Copy link
Member

Byron commentedAug 14, 2019•
edited
Loading

@kangp3 Thus far, maintaining two versions wasn't planned, but I will see if I can get a one-off release done.

Published in release v2.1.14 .

kangp3 reacted with hooray emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
@FrNecas@Byron@kangp3
[8]ページ先頭
©2009-2025 Movatter.jp