Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork940
BF: install_requires not just requires for setup() call#873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
BF: install_requires not just requires for setup() call#873
Conversation
Originally detected while running DataLad tests on CRONdatalad/datalad#3395
codecov-io commentedMay 7, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #873 +/- ##======================================= Coverage 94.79% 94.79% ======================================= Files 59 59 Lines 9607 9607 ======================================= Hits 9107 9107 Misses 500 500 Continue to review full report at Codecov.
|
I think this one is obvious so I will just merge it |
Originally detected while running DataLad tests on CRONdatalad/datalad#3395 although mystery remains why not earlier.
To say the truth I am not fan of the approach (defer to reading requirements.txt) introduced ince21f63 but I guess it is a separate issue