Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

read workdir from git.config as referenced in man 1 git-config#808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

fscherf
Copy link

Hi@Byron,

I am a co-worker of@Farom and we need his PR#801 merged for one of our future projects. He had no time to add the last feedback so i edited his patch.

@fscherffscherfforce-pushed thefscherf/farom/worktree_from_config branch from43803ef to3863e9eCompareNovember 8, 2018 11:29
@codecov-io
Copy link

Codecov Report

Merging#808 intomaster willincrease coverage by13.56%.
The diff coverage is85.71%.

Impacted file tree graph

@@            Coverage Diff             @@##           master    #808       +/-   ##==========================================+ Coverage   80.24%   93.8%   +13.56%==========================================  Files          59      59                 Lines       11067    9386     -1681     ==========================================- Hits         8881    8805       -76+ Misses       2186     581     -1605
Impacted FilesCoverage Δ
git/repo/base.py94.38% <85.71%> (+17.21%)⬆️
git/compat.py54.32% <0%> (-3.7%)⬇️
git/test/test_fun.py97.84% <0%> (-1.08%)⬇️
git/test/test_base.py96.42% <0%> (+1.02%)⬆️
git/refs/head.py98.9% <0%> (+1.07%)⬆️
git/test/test_config.py98.33% <0%> (+1.61%)⬆️
git/exc.py96.42% <0%> (+1.69%)⬆️
git/repo/fun.py92.02% <0%> (+2.33%)⬆️
git/objects/base.py95.83% <0%> (+3.83%)⬆️
git/index/util.py90.69% <0%> (+4.03%)⬆️
... and38 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update3e1fe7f...3863e9e. Read thecomment docs.

@fscherf
Copy link
Author

i know the tests fail, but is this my fault? Both fails seem like ci config problems.

@ByronByron merged commit530ab00 intogitpython-developers:masterDec 22, 2018
@ByronByron added this to thev2.1.12 - Bugfixes milestoneDec 22, 2018
@Byron
Copy link
Member

Sorry for the late reply, and thanks a lot for the contribution.

I do hope to get the tests fixed at some point, being in a red state for too long makes me quite fearful of merging more than typo-fixes in future.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
@fscherf@codecov-io@Byron@Farom

[8]ページ先頭

©2009-2025 Movatter.jp